I think there's a bug with CLJS 1.10.891 regarding importing the top-level goog ns

(ns main.goog-issue
  (:require [goog]))

(goog/typeOf "")

clj -Sdeps '{:deps {org.clojure/clojurescript {:mvn/version "1.10.758"}}}' -M --main cljs.main --compile main.goog-issue yields

// Compiled by ClojureScript 1.10.758 {}
goog.provide('main.goog_issue');
goog.require('cljs.core');
goog.typeOf("");

//# sourceMappingURL=goog_issue.js.map

clj -Sdeps '{:deps {org.clojure/clojurescript {:mvn/version "1.10.891"}}}' -M --main cljs.main --compile main.goog-issue blows up with

Unexpected error (ExceptionInfo) compiling at (REPL:1).
No such namespace: goog, could not locate goog.cljs, goog.cljc, or JavaScript source providing "goog" in file /Users/orestis/dev/clj-kondo-cljs-bug/src/main/goog_issue.cljs

Full report at:
/var/folders/5d/6gc_14214js5lwj2j8llw0vm0000gn/T/clojure-8016216251114526219.edn

@orestis you don't need to require top level goog btw, it's kind of anti pattern since it's not a thing

that it is not a namespace

that said, it might be a regression though I thought we had internal tests for that already

Oh so I could just directly use goog/typeOf? Like we do js/console?

yes

perfectly valid

@orestis what happened is that Google Closure dropped deps.js from Closure Library

and so now we generate it and we've had to recreate the various quirks

I think goog used to be in there - so it happened to work

if more people report it can think about reintroducing it - but again it's not necessary

Funny thing is that shadow-cljs accepts it happily (using the same cljs version) so it's not really a regression for our project. Just something we happened to notice by accident.

$ clj -Sdeps '{:deps {org.clojure/clojurescript {:mvn/version "1.10.891"}}}' -M -m cljs.main -re node
Downloading: org/clojure/clojurescript/1.10.891/clojurescript-1.10.891.pom from central
Downloading: org/clojure/clojurescript/1.10.891/clojurescript-1.10.891.jar from central
ClojureScript 1.10.891
cljs.user=> goog/typeOf

But perhaps REPL is a special beast.

Oh, eventually it came back: #object[Function]

I did notice one regression I mentioned here or in #clojurescript but didn't get feedback on yet:

cljs.user=> (require '[clojure.string :as str] :reload)
Execution error (TypeError) at (<cljs repl>:1).
Cannot read property 'remove' of undefined

This used to work

(clojure.string is just a random example here, it happens with any namespace I try to reload)

This shows that it used to work:

$ clj -Sdeps '{:deps {org.clojure/clojurescript {:mvn/version "1.10.879"}}}' -M -m cljs.main -re node
ClojureScript 1.10.879
cljs.user=> (require '[clojure.string :as str] :reload)
nil

@dnolen should there be a mention of goog like http://cljs.github.io/api/syntax/#js-namespace

it's a simple fix and not to ClojureScript actually, just the GCL custom build we do - so will patch it up

https://clojure.atlassian.net/browse/CLJS-3336

@borkdude thanks for bringing that up again fixing

@borkdude https://clojure.atlassian.net/browse/CLJS-3337 fixed give it a try when you have time

it was a bit specific to Node.js - so didn't notice

@dnolen that was fast. confirming:

$ clj -Sdeps '{:deps {org.clojure/clojurescript {:git/url "" :git/sha "02b450af9c5f3a1fa2ee949c28c3a671987d7e54"}}}' -M -m cljs.main -re node
Cloning: 
Checking out:  at 02b450af9c5f3a1fa2ee949c28c3a671987d7e54
ClojureScript 0.0.1828047738
cljs.user=> (require '[clojure.string :as str] :reload)
nil
cljs.user=>

nice

thanks 🎉

@orestis very strange it works in a REPL

Hrm, ok I've reproduced it and added some details to the ticket

I can't find how the http://cljs.github.io/api/ is generated. Nor clojure/clojurescript or clojure/clojurescript-site bring up any results...

It seems that closure-compiler-unshaded is no longer unshaded, closure-compiler-unshaded-v20210808.jar contains jsr250-api, jsr305, guava, etc.

Which means it conflicts with org.apache.maven/maven-core (dependency of tdeps).

I don't think there's any solution

Should probably be reported. There also a new release to check.

@orestis those docs are external

Where would I report that?