Closure compiler mailing list

I noticed that tools.namespace doesn't work for a few CLJS cases: 1. it does not understand string requires (which are typically used for NPM deps), it throws on them 2. it does not take into account :require-macros I'm maintaining a fork of tools.namespace that is compatible with babashka and fixed it in the fork. I am using this fork to detect which macro namespaces are used from a set of .cljs files, to calculate a hash and download the advanced build from elsewhere if it's already available in cloud storage. https://github.com/babashka/tools.namespace/commit/8f44ac78798eaf7078cc9ad93fbe1f45bbe9c3c4#diff-cb6f40623e14bf72e25ddaf89bc83c20a3aafa5076ad2c8cadf98a4d609f0b70 https://github.com/babashka/tools.namespace/commit/a13b037215e21a2e71aa34b27e1dd52c801a2a7b#diff-cb6f40623e14bf72e25ddaf89bc83c20a3aafa5076ad2c8cadf98a4d609f0b70 Is there any interest in receiving those fixes back (if they are considered appropriate)?

Sure! I can help with that if you want to provide patches

@alexmiller sure. do I need to make a JIRA issue for both?

or ask.*?

a jira would be helpful just so we have something for tracking. if they are both in the bucket of "cljs compatibility", I think it could just be one jira

I'll describe the issues here, so perhaps @dnolen can verify if my changes make sense. Issue 1.

(ns foo (:require ["some-npm-dep"] [normal.cljs.dep]))

Issue 2.

(ns foo (:require-macros [clj.dep :refer [x y z]]))

I feel like maybe one or both of these are existing jiras

https://clojure.atlassian.net/browse/TNS-51 is the first one

indeed

@borkdude yep that sounds right

@alexmiller I'll try to provide a patch for TNS-51 later this week. For the other issue I'll make a new JIRA + patch.

:thumbsup:

@quoll @dnolen fyi re cljs math stuff https://clojure.atlassian.net/browse/CLJ-2673 (removes min + max, moves abs to core), also https://clojure.atlassian.net/browse/CLJ-2672 for the docstring fix

if you have a confidence level that cljs can support all (or nearly all) the math functions, that would be useful to know. doesn't have to be done, just looking for whether you believe it can be

I'm happy to see the collaboration on this!