Done!

amazing thank you!

fyi, we now bump both the jvm and bb pod at the same time, so there's a +1 to 'number of people needing coordinated releases' for your usage data 🙂

I should remember to do this when releasing clj-kondo

that's be lovely, yes please 😄

ooh a fellow hashp user! 👋:skin-tone-3:

currently not, but there is a :config-in-tag option which configures linting behavior in tags. Not sure if this will help in this case, probably not

loving #p a ton, but occasionally it slips into commits thanks for a prompt reply

I know. My secret is that I never add it to the checked-in deps.edn, just keep it in my user-level one so in theory it should fail compilation

I'm not exactly sure why this case isn't detected

$ echo "(let [uuids [{:a 1}]] (map #(:a %) uuids))" | clj-kondo --lint - --config "{:linters {:redundant-fn-wrapper {:level :error}}}" --cache false
linting took 8ms, errors: 0, warnings: 0

I'd have to look into how it works again, it's been a while

I also found that in some cases redundant-fn wrappers are still desirable, e.g. for hot reloading

So I haven't enabled it anymore locally

https://github.com/clj-kondo/clj-kondo/pull/1832

Thanks for the PR. I'm going to check if I can see some interesting new discoveries when I'm running the lint diff

Sometimes you can discover cases that aren't working properly, so that would be good before merge

no rush! just something I noticed after cleaning up the existing lint warnings in our production codebase

< clojure/inspector.clj:120:17: warning: Redundant fn wrapper
3125d3123
< sci/impl/utils.cljc:204:38: warning: Redundant fn wrapper
3367c3365

nice: https://github.com/clojure/clojure/blob/5da21b38470d175b3cecbf93b9cd145ca36940c1/src/clj/clojure/inspector.clj#L120

nice: https://github.com/babashka/sci/blob/2b987b90df613daedf321c0987d8e4d5fe2465c6/src/sci/impl/utils.cljc#L204

Fine with me

Also: cljs only

Right, I'll include that

Is that something you want to warn about or just skip if in clojure?

looks like we're not doing such checks for other :require options

in clojure this is not a valid option

so that's an unknown-require-option then

Perhaps in a .cljc situation it's convenient to leave it in, if it also works for clojure

I mean that :refer-macros is allowed in clojure, but we could lint it:

$ clj
Clojure 1.11.1
user=> (require '[clojure.string :refer-macros [join]])
nil
user=> (join " " (range 10))
Syntax error compiling at (REPL:1:1).
Unable to resolve symbol: join in this context

yeah, clojure doesn't care

Everything is allowed right

https://github.com/clj-kondo/clj-kondo/pull/1834

This works but doesn't feel ideal so let me know how you want to go with it

To me this feels way too much for simple syntax check, I wouldn't even introduce a new linter for this. Just a warning with type :syntax

Oh yeah, I completely forgot about that one. Thanks, I’ll clean it up

Updated, much simpler now. I included a change to make :unknown-require-option default to :off, which should help everyone out in general