This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2022-10-07
Channels
- # announcements (2)
- # babashka (34)
- # beginners (114)
- # biff (7)
- # calva (16)
- # cider (2)
- # clj-kondo (46)
- # clj-on-windows (14)
- # clojars (13)
- # clojure (33)
- # clojure-europe (17)
- # clojure-nl (2)
- # clojure-norway (8)
- # clojure-spec (3)
- # clojure-uk (3)
- # clojurescript (25)
- # community-development (1)
- # datalevin (1)
- # emacs (53)
- # fulcro (31)
- # gratitude (2)
- # jobs (1)
- # lambdaisland (12)
- # lsp (57)
- # malli (3)
- # nbb (1)
- # off-topic (92)
- # pathom (2)
- # pedestal (2)
- # releases (5)
- # shadow-cljs (25)
- # sql (3)
- # squint (1)
- # testing (6)
- # vim (11)
@borkdude clj-kondo does not know about :include-macros
require option (“Unknown require option: :include-macros”)?
https://clojurescript.org/guides/ns-forms
(ns bar.core
(:require [foo.core :as foo :include-macros true]))
should I file an issue?@serioga Thank you. There is already an issue and PR for this, I will merge this soon
@borkdude will it be accepted in CLJ files too? Or I shoud use reader conditionals in CLJC files? At least Clojure compiler does not complain about this option.
@serioga Good data point, thank you. If the Clojure compiler doesn't complain, then perhaps we should just let this slide inside a .cljc
file
Does clj-kondo know it’s in a cljc file? I thought it just ran twice, one for each dialect
Yes, it knows, in the context we have :base-lang and :lang. :base-lang can be :cljc
Cool, I’ll check for that. Will be on my computer and fix the pr in an hour or two.
@nbtheduke Clojure does not complain about :include-macros in CLJ file too 🙂
Clojure doesn't complain about anything, but the point of that linter is to prevent typos by adding options that don't do anything
If you're not interested in that, just don't use the linter, it is disabled by default
@borkdude which linter is disabled by default? At the moment “clj-kondo v2022.10.05” warns me about :include-macros and I did not enable it AFAIK
aw crap, this slipped through: https://github.com/clj-kondo/clj-kondo/blob/5eaa490efef7041c97d990620cca2403b2d18d81/src/clj_kondo/impl/config.clj#L39
Hmm, I see... https://github.com/clj-kondo/clj-kondo/pull/1808#issuecomment-1246503198
Oops, also my bad. Sorry about all this
No problem, people can always use #_:clj-kondo/ignore
I think but I don't want to disturb anyone's CI by upgrading blindly ;)
@nbtheduke Now that we have the linter on in the current clj-kondo anyway, I've thought about it some more and maybe we should just leave it on, but I want to have an option to add options (for custom languages like clojuredart, or whatever is to come) to add options that should not be warned about, I think
How do you want it to look?
@nbtheduke Perhaps we should also add an option to this so people can exclude certain options in user space
@borkdude will it be accepted in CLJ files too? Or I shoud use reader conditionals in CLJC files? At least Clojure compiler does not complain about this option.
linter idea: functions that should probably not be used as the reducing function in a call to transduce
based on https://twitter.com/cgrand/status/1578401747835445252
oof, that's complicated