This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2020-03-31
Channels
- # announcements (4)
- # aws (1)
- # babashka (52)
- # beginners (178)
- # boot (4)
- # cider (2)
- # clj-kondo (10)
- # cljs-dev (39)
- # clojure (744)
- # clojure-europe (12)
- # clojure-germany (6)
- # clojure-india (56)
- # clojure-italy (5)
- # clojure-nl (60)
- # clojure-spec (9)
- # clojure-sweden (14)
- # clojure-uk (36)
- # clojuredesign-podcast (6)
- # clojurescript (11)
- # community-development (5)
- # core-async (4)
- # data-science (6)
- # datomic (6)
- # emacs (7)
- # events (4)
- # exercism (33)
- # fulcro (11)
- # funimage (2)
- # graalvm (29)
- # java (1)
- # joker (3)
- # lambdaisland (15)
- # malli (2)
- # meander (55)
- # mid-cities-meetup (1)
- # nrepl (8)
- # observability (4)
- # off-topic (2)
- # pathom (5)
- # re-frame (31)
- # shadow-cljs (73)
- # spacemacs (18)
- # sql (27)
- # test-check (14)
- # testing (1)
- # tools-deps (5)
- # xtdb (13)
Created an open collective for those who prefer it over Github sponsors. https://opencollective.com/clj-kondo
thanks @jeroenvandijk / adgoji for the generous contributions
Thank you!
Any feedback on this PR? https://github.com/borkdude/clj-kondo/pull/826
My thoughts: the name could be clearer. Maybe get-in-single-key
? Also I'm not sure: should we turn on this linter by default?
Also: could it be generalized to assoc-in, update-in?
I never really thought of (get-in x [:k])
an anti-pattern, so I'd probably lean towards turning this linter off if it was turned on by default. But that's of course just my personal opinion, interested to hear what others think
@borkdude I would definitely turn this linter on, if it wasn't on by default (as long as it doesn't give false positives). It's fair to extend it to assoc-in
but with update-in
you need to bear in mind that we didn't have update
until Clojure 1.7 so a lot of older code had to have update-in
with [:k]
.
Sorry, wasn't sure whether you wanted the feedback here or in the PR.