Fork me on GitHub
#calva
<
2019-10-15
>
pez07:10:42

@aengelberg, sorry for leaving you hanging. It is just that I have no clues and just don’t know how to approach the issue. But there is hope. I just saw activity from someone in-the-know on this ticket: https://github.com/BetterThanTomorrow/calva/issues/248

andres.rodriguezhn07:10:47

Whoa, hey @pez. Long time no see, hope you're doing fine. simple_smile I just noticed there are a lot of issues occurring with WSL, and I was the one who worked on it. πŸ˜…

andres.rodriguezhn07:10:14

I think the main reason is due to the Remote Development Extension. When I added support for WSL, this extension didn't exist before.

andres.rodriguezhn07:10:51

So things are now different. The useWSL flag should be avoided if using this extension.

pez07:10:09

There you are, @andres.rodriguezhn! I just summoned you on Github. πŸ˜ƒ

andres.rodriguezhn07:10:28

In fact, with this extension, any special logic I added for WSL should be removed. I believe it should now work without adding any special validations.

aengelberg16:10:49

I was wondering about that, thanks for confirming

pez07:10:17

PR welcome! Both @c.fehse and @slack1038 are Windows users (well at least CF has WIndows available) so we should be able to work together to remove confusion and get this WSL business in some control.

andres.rodriguezhn07:10:20

I have been a little busy lately but I will try to make some time for this, seems like plenty of people need it! simple_smile

andres.rodriguezhn07:10:17

I'm glad to have checked on the status of this project after I received a notification from @c.fehse when he closed this issue I opened 8 months ago haha https://github.com/BetterThanTomorrow/calva/issues/139

andres.rodriguezhn07:10:10

Also glad to see that it's still going strong :)

c.fehse07:10:09

@aengelberg This is an issue with vscode 1.39.1. The bug is filed and the fix is merge there. Should be fixed in the next in recovery release of vscode coming this week.

aengelberg16:10:32

cool, thank you!

pez07:10:44

Happy to have your attention on this @andres.rodriguezhn!

c.fehse08:10:25

@andres.rodriguezhn I just created a PR which addresses this flag. I think the flag can make sense if you starts a repl in wsl and connects from windows to it. If vscode is used with the wsl extension the flag is now ignored.

pez08:10:48

I think that a part of the fix should be to make it as clear as possible what's going on. Are there cases where this flag doesn't matter and where the user might get the impression that it matters? A good place to start is probably in the documentation of using Calva with WSL. So first we write down, in docs/readthedocs/source/wsl.md, how we think would be a good way that it works. And then we look at the implementation so that it adheres to the documentation.

c.fehse09:10:43

But first we merge my PR because the current implementation is harmful and breaks the definition provider is the flag is when it should not be set. gg

tamizh8811:10:25

@pez Do we have any single command to restart the running REPL? Currently, I am using Ctrl+C in the terminal and then jack-in again.

pez11:10:30

Jack-in will do it. (I.e. you can skip the ctrl+c there.)

tamizh8801:10:47

Thanks πŸ™‚

pez15:10:36

@andres.rodriguezhn, can you help us test this VSIX? It has @c.fehse’s fix for not letting the useWSL setting mess things.

pez20:10:50

Calva 2.0.51 is out! Containing the latest batch of improvements by @c.fehse https://github.com/BetterThanTomorrow/calva/releases/tag/v2.0.51

hoppy23:10:42

just fyi to all on a bogey. Associate tried to jack-in a clojure project, and was having problems, and it ultimately was because of a stale version of VS-Code. We both run arch, so are updating with AUR packages, and his was a couple of months out of date. Calva must be pretty bleeding edge.... :face_with_cowboy_hat: