2022-06-24 tools-build | Clojure Slack Archive

tools-build 2022-06-24

jumar 2022-06-24T07:35:26.208489Z

I'm a tools.build noob and trying to quickly build an uberjar. I followed the instructions here: https://clojure.org/guides/tools_build But when I try to build it I get this error:

clj -T:build uber
Error building classpath. Bad coordinate for library :ns-default, expected map: build

What am I doing wrong? My build.clj is here: https://github.com/jumarko/clojure-experiments/pull/5/files#diff-5e404fc7ef47dfb3139017bcd1ff83f7c1214c3f5d3f73fcde5f4ca466b59f16 (deps.edn below)

dominicm 2022-06-24T09:15:05.806019Z

Your deps.edn had a misplaced }.

dominicm 2022-06-24T09:15:17.161989Z

:ns-default shouldn't be part of :deps

jumar 2022-06-24T09:20:52.715259Z

Ah, great catch - thanks!

Darin Douglass 2022-06-24T19:48:02.950439Z

@seancorfield i’m using build-clj to build an uberjar with some git deps that i need to include. i’m using :transitive true to get the git deps into the uberjar proper. one of the git deps has a transitive dependency https://github.com/cognitect-labs/aws-api/issues/205#issuecomment-1164833972`data.xml`, so i’ve added an :exclusion. this works in the repl, etc. however that excluded dep shows up in the uberjar. i did some digging and it looks like lifted-basis doesn’t propagate exclusions from parent libs. is this intentional? (i’ve not used polylith so i’m not sure if there’s a reason hidden there somewhere)

seancorfield 2022-06-24T19:50:41.462179Z

Can you create a minimal, self-contained example as a GitHub repo, and create an issue against build-clj pointing to that with complete, step-by-step instructions?

Darin Douglass 2022-06-24T19:50:52.605359Z

yessir

seancorfield 2022-06-24T19:50:58.811999Z

I'm finding it hard to visualize what you're describing without seeing it all in code.

Darin Douglass 2022-06-24T19:51:14.407479Z

ya i feel that, i’ll ping when it’s up

seancorfield 2022-06-24T19:58:38.714909Z

I suspect https://github.com/seancorfield/build-clj/blob/main/src/org/corfield/build.clj#L128 should use (select-keys coords [:mvn.version :exclusions]) (and a bit of tidying up in that whole conditional -- it doesn't support :default-deps either right now, based on expecting :mvn.version to be non-`nil`.

Darin Douglass 2022-06-24T19:59:24.262909Z

ya, tinkering around and using :exclusions from (:parents coords) worked locally for me

seancorfield 2022-06-24T20:00:52.426599Z

OK, no need for a MSCE repo -- but please still create the issue so I don't forget (I'm deep in Java interop/rewriting ATM).

🙇‍♂️ 1

✅ 1

Darin Douglass 2022-06-24T20:15:21.399669Z

https://github.com/seancorfield/build-clj/issues/23

seancorfield 2022-06-24T20:20:07.354079Z

@douglassdarin Could you try build-clj with :git/sha "5b86a6e7c600993cbde06133bf9c7632f2cb3a1f" (and comment out the :git/tag for now) and see if that fixes the problem?

seancorfield 2022-06-24T20:20:22.556609Z

I just want to see if my supposition is correct.

Darin Douglass 2022-06-24T20:20:28.388639Z

sure, one sec

Darin Douglass 2022-06-24T20:23:31.445369Z

❯ jar tf target/*.jar | grep aalto
❯

Darin Douglass 2022-06-24T20:24:09.748939Z

looks good to me

seancorfield 2022-06-24T20:24:44.078199Z

Thank you! I'll try to get a proper updated release out "soon" but it may be next week...

Darin Douglass 2022-06-24T20:25:08.779929Z

no worries, i’ve a workaround in place at the moment

seancorfield 2022-06-24T20:25:40.506889Z

I may wait until there's a new tools.build version so I don't have to think about version numbers 🙂

Darin Douglass 2022-06-24T20:26:32.443819Z

lol i feel that 😛

Clojurians Log v2

tools-build 2022-06-24