One little gotcha that we’ve stumble upon is that something like

(-> (hh/delete-from :foo) (hh/where (map clauses nil-xs)))

@slipset HoneySQL has a couple of modes where it highlights "unusual" conditions etc -- do you think it would be worth a check on :delete-from to ensure it has a non-empty condition and warn/throw on that?

Not sure what would be a general solution, but I’ve done this in our specific case.

Basically just providing a problem with one possible solution 🙂

One could argue that this would be a problem with update as well. I know I’ve fat fingered updates without clauses in a console.

Read over what :checking does in https://cljdoc.org/d/com.github.seancorfield/honeysql/2.2.891/doc/getting-started?q=checking#format-options and let me know if you think extending that to delete from and update would help (by creating an issue). Someone who genuinely wants to delete/update all rows could added a dummy true condition to suppress it (which I see a lot of people doing in SQL anyway with WHERE 1 = 1)

I guess (hh/where nil) could be flagged?

I’ll open an issue