Fork me on GitHub
#tools-build
<
2022-06-25
>
markaddleman14:06:51

@seancorfield I've run into a problem with build.clj : When I include tick/tick {:mvn/version "0.5.0-RC6"} as a dep, build.clj throws an exception as part of its conflict_data_readersfunction. I'm guessing there is a reader macro from tick conflicts with a reader macro from another library. I have about 30 dependencies so it's hard to narrow down where the conflict is coming from. Do you have a suggestion on how to debug?

seancorfield16:06:01

That exception is coming from tools.build itself, inside the core uber task -- it is not coming from my wrapper.

seancorfield16:06:49

Since it is complaining about #? I'm guessing there's a reader conditional inside one of the data_readers.cljc files in one or more of the libraries you are including.

seancorfield16:06:53

tools.build is reading those files as EDN -- I have no idea about reader conditional support in EDN but based on Qs on http://ask.clojure.org, it seems that they are supported in data_readers.cljc files -- see various posts there https://ask.clojure.org/index.php/search?q=data_readers

seancorfield16:06:54

@U064X3EF3 is best placed to provide more information but I suspect this is something that needs to be posted as an issue on http://ask.clojure.org @U2845S9KL and then Alex will turn it into a Jira issue if appropriate.

Alex Miller (Clojure team)16:06:22

Yeah, I'd you file a question I'll look at it Monday

Alex Miller (Clojure team)19:06:31

hey, can you give this a try with: io.github.clojure/tools.build {:git/sha "0d20256c40b5a6b6adbcbdf7d0c52cf9e22e994d"}

markaddleman19:06:55

Thanks. I'll give it a try in a few minutes

Alex Miller (Clojure team)19:06:00

If that looks good, I'll do a release

seancorfield19:06:54

@U064X3EF3 Is there a danger that will execute arbitrary code while reading/merging those files? I know that would get executed when programs are run and that's such "arbitrary code" is very unlikely in data_readers but just wondered whether it might be unexpected while building an uberjar?

markaddleman19:06:33

@U064X3EF3 fix looks good. thanks!

Alex Miller (Clojure team)19:06:42

@seancorfield I am binding read-eval to false

seancorfield19:06:56

Oh, totally missed that -- sorry.

seancorfield19:06:20

Line 87. I see it now!

Alex Miller (Clojure team)19:06:04

ok, that is now {:git/tag "v0.8.3" :git/sha "0d20256"}

🙏 1
1