Clojurians Log v2

hey, can you give this a try with: io.github.clojure/tools.build {:git/sha "0d20256c40b5a6b6adbcbdf7d0c52cf9e22e994d"}

Thanks. I'll give it a try in a few minutes

If that looks good, I'll do a release

@alexmiller Is there a danger that will execute arbitrary code while reading/merging those files? I know that would get executed when programs are run and that's such "arbitrary code" is very unlikely in data_readers but just wondered whether it might be unexpected while building an uberjar?

@alexmiller fix looks good. thanks!

@seancorfield I am binding read-eval to false

so no

Oh, totally missed that -- sorry.

Line 87. I see it now!

ok, that is now {:git/tag "v0.8.3" :git/sha "0d20256"}

That exception is coming from tools.build itself, inside the core uber task -- it is not coming from my wrapper.

Since it is complaining about #? I'm guessing there's a reader conditional inside one of the data_readers.cljc files in one or more of the libraries you are including.

tools.build is reading those files as EDN -- I have no idea about reader conditional support in EDN but based on Qs on http://ask.clojure.org, it seems that they are supported in data_readers.cljc files -- see various posts there https://ask.clojure.org/index.php/search?q=data_readers

@alexmiller is best placed to provide more information but I suspect this is something that needs to be posted as an issue on http://ask.clojure.org @markaddleman and then Alex will turn it into a Jira issue if appropriate.

Yeah, I'd you file a question I'll look at it Monday

Thanks, guys. Posted question https://ask.clojure.org/index.php/12017/exception-in-ednreaderdispatchreader