Firstly thanks for a great product! So I wanted to experiment with adding NPM lib react-native-logs to my react-native shadow-cljs project, so I yarn'd it, created a new namespace and added ["react-native-logs" :refer [logger]] but nothing I did could get logger to appear in the REPL (loading file or namespace) in a way that made sense. I thought maybe it was an ecma issue and tried react-native-logs$default, tried :as instead, but nothing worked. I got AssertionError Assert failed: (rc/valid-resource? rc)errors in the shadow-cljs console :thinking_face:. However it all worked perfectly if I used it from within the :app main namespace, or even required the new namespace from a linked one ❗ Obviously very unlike a Clojure REPL experience. I was wondering if it would be possible to give a hint in this scenarios so others don't suffer the hours it took me 😅

dependencies cannot be added solely from the REPL in react-native

that is because the code needs to be processed by the react-native metro build tool and it cannot see what you do at the REPL

Can shadow not see this attempt and warn the user?

I thought it did https://github.com/thheller/shadow-cljs/blob/fd7360dd334119283242eb85340ed04aa16310ac/src/main/shadow/boot/react-native.js#L40

but I don't use react-native myself so maybe that check just does nothing and it blows up in other ways

I mean what is AssertionError Assert failed: (rc/valid-resource? rc) and in which context did you get it?

so far nobody has opened an issue about this so I assume everything is fine in react-native land 😉

[2022-07-29 13:08:26.165 - WARNING] :shadow.cljs.devtools.server.util/handle-ex - {:msg {:op :cljs-compile, :input {:code "(cljs.core/load-file \"/Users/dmg46664/projects/samson/src/main/dimigi/network.cljs\")", :ns user, :repl true}, :include-init false, :call-id 5, :from 3}}
AssertionError Assert failed: (rc/valid-resource? rc)
	shadow.build.data/add-source (data.clj:220)
	shadow.build.data/add-source (data.clj:220)
	shadow.cljs.repl/repl-ns (repl.clj:325)
	shadow.cljs.repl/repl-ns (repl.clj:319)
	shadow.cljs.repl/process-read-result (repl.clj:504)
	shadow.cljs.repl/process-read-result (repl.clj:484)
	shadow.cljs.repl/process-input (repl.clj:647)
	shadow.cljs.repl/process-input (repl.clj:625)
	shadow.cljs.repl/repl-load-file* (repl.clj:281)
	shadow.cljs.repl/repl-load-file* (repl.clj:259)
	shadow.cljs.repl/repl-load-file (repl.clj:317)
	shadow.cljs.repl/repl-load-file (repl.clj:315)

hmm didn't I fix that one? which version do you use? (its printed on startup)

Damn, I just realised I upgrade recently by changing the shadow dependency and not yarning the shadow upgrade 😬

you can also set :version "2.19.8" in shadow-cljs edn if you want to be less reliant on npm/yarn stuff

(only works if you don't use deps.edn/project.clj of course)

Oh, that's what I did, but in the edn file.

deps.edn

shadow-cljs - server version: 2.19.8 running at 

well, yes with deps.edn the version is managed in deps.edn and package.json version doesn't really matter for compilation

so you get that error with that version?

😅 yes get that error in that version... but before upgrading from 2.11.7 I got a little more out of the stacktrace:

"react-native-logs" - failed: simple-symbol? in: [:requires 3] at: [:requires] spec: :shadow.build.resource/require

info from 2.11.7 doesn't help and just confuses the issue

please open an issue with the above stacktrace and some info on how you got it

I'll see about fixing that

Cool, I thought best here before opening an issue.

Oh, is it relevant that I'm using cider-nrepl as well?

might be yes

Errors encountered while trying to parse file
  /home/tianshu/workspace/race-poker/racepoker-dapp/node_modules/lower-case/dist/index.js
  {:line 13, :column 13, :message "Character '̇' (U+0307) is not a valid identifier start char"}

"use strict";
Object.defineProperty(exports, "__esModule", { value: true });
exports.lowerCase = exports.localeLowerCase = void 0;
/**
 * Source: 
 */
var SUPPORTED_LOCALE = {
    tr: {
        regexp: /\u0130|\u0049|\u0049\u0307/g,
        map: {
            İ: "\u0069",
            I: "\u0131",
            İ: "\u0069",
        },
    },
...

no, that is a known error in the closure compiler. unfortunately nothing I can do about it

https://github.com/google/closure-compiler/issues/3639

Ah, I see.

Can I patch this some how, I mean provide another file to overwrite this js

I changed the file in node_modules, then it goes to an infinite compiling status.

don't know what that means. be careful when changing that file. you might leave invalid characters due to the non-visible unicode stuff

I just commented them. When the compiling can't complete, how can I investigate what's going on?

what do you mean by "can't complete"? I can't see your screen so I cannot guess what you are doing

any error during compilation should be logged somewhere

if you use something like cider the error might be in some other hidden buffer or something

I recommend running shadow-cljs in the terminal somewhere to ensure you see all output

Let me try it without cider

You are right

Now I see the errors

yeah someone else reported a similar situation

https://github.com/thheller/shadow-cljs/issues/1029

Does it mean there's some malformed require

maybe a have a similar cause? ie. changing the package folder name but not the package.json name?

Trying to understand the solution mentioned in this issue

well if you answer my question that is also the solution 😛

suppose you created a node_modules/my-lower-case and just copied the original package.json file there

without updating the name field inside it

Hmm, nope. I just comment the content of that object definiation.

I didn't change anything else, on my refresh new installed node_modules

I'm sure it's caused by some packages, but I don't know which one it is. Because I introduce one package which bring me a lot dependencies

https://github.com/thheller/shadow-cljs/issues/1029#issuecomment-1183296479

do this then

Let me try

I can understand this code here, but it doesn't give me anything in the inspector. Nor it does with print instead of tap>.

shadow.user=> (alter-var-root #'shadow.build.npm/find-resource-in-package
  (fn [orig]
    (fn [npm package require-from rel-require]
      (try
        (orig npm package require-from rel-require)
        (catch Exception e
          (tap> [:what rel-require package require-from])
          (throw e))))))
#object[shadow.user$eval25371$fn__25372$fn__25373 0xead9010e "shadow.user$eval25371$fn__25372$fn__25373@ead9010e"]
shadow.user=> (shadow/compile :app)
[:app] Compiling ...
Execution error (AssertionError) at shadow.build.npm/find-resource-in-package (npm.clj:686).
Assert failed: (str/starts-with? rel-require "./")
shadow.user=> (alter-var-root #'shadow.build.npm/find-resource-in-package
  (fn [orig]
    (fn [npm package require-from rel-require]
      (try
        (orig npm package require-from rel-require)
        (catch Exception e
          (println [:what rel-require package require-from])
          (throw e))))))
#object[shadow.user$eval25784$fn__25785$fn__25786 0xa9377baa "shadow.user$eval25784$fn__25785$fn__25786@a9377baa"]
shadow.user=> (shadow/compile :app)
[:app] Compiling ...
Execution error (AssertionError) at shadow.build.npm/find-resource-in-package (npm.clj:686).
Assert failed: (str/starts-with? rel-require "./")

I think I did it the right way.

hmm odd. looks correct.

but again ... when in cider it is undefined where println goes

when you run shadow-cljs clj-repl did it start a new instance

or did it say "connected to server"

Now I'm using command line

Yep, it said "starting via clojure"

hmm weird

Thanks anyway, I think I got the idea. I can test more with this method

which version do you use?

2.19.1

hmm line number seems to match with the current. not sure why this wouldn't work

I mean you can just (throw (ex-info "a more helpful error" {:package package}) e))

instead of (throw e)

but I mean println or tap should both be fine too

I'll probably just add something like that given how unhelpful assert errors are

Hmm, I got some progress

I print the package before call the orig . But it shows me a package I used to have it in my project.

It's parrerell?

Hm, yes, it's a package which I had before. The rel-require here is

.-v2

It doesn't look like a require at all

😂So, there's one package call spl-token, and now there's a package called spl-token-v2. JS is Amazing

hmm yeah I need to rewrite that code I guess 😛

I just assumed that npm actually checks the name and stuff but I guess it doesn't