Fork me on GitHub
#honeysql
<
2022-07-29
>
orestis06:07:22

Yesterday I opened a PR that completely removes honeysql v1 from our codebase. I wanted to say thank you @seancorfield for making this possible with the good decisions of honeysql v2. Much appreciated!

1
👍 1
seancorfield09:07:58

Is the migration from 1.x to 2.x something you might write up as a blog post or something?

orestis10:07:57

It was rather boring to be honest! The best kind of migration.

1
orestis10:07:17

We introduced the new library, decreed that no more new v1 code, and no changes to v1 code (if you want to change, rewrite to v2 first).

orestis10:07:18

The new namespace was critical to be able to do it. If it was an in-place update, we wouldn't do it.

1
seancorfield15:07:40

That sounds like how we're doing our migration too 🙂

seancorfield23:07:49

I thinking about https://github.com/seancorfield/honeysql/issues/413 and wondered how many people are using the :checking option already? I'm considering adding checks to :delete, :delete-from, and :update to throw an exception if there is no :where clause present or the :where conditions are empty -- if :checking :strict (or perhaps :checking :basic). Are there valid scenarios for these three statements that do not delete/update all rows but also do not have WHERE clauses?