This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2018-12-12
Channels
- # adventofcode (135)
- # announcements (1)
- # beginners (192)
- # boot (5)
- # calva (130)
- # cider (42)
- # cljdoc (4)
- # cljs-dev (6)
- # cljsrn (3)
- # clojure (222)
- # clojure-europe (2)
- # clojure-greece (5)
- # clojure-italy (24)
- # clojure-nl (23)
- # clojure-russia (1)
- # clojure-spec (6)
- # clojure-uk (67)
- # clojurescript (35)
- # cursive (39)
- # datomic (61)
- # emacs (17)
- # figwheel (3)
- # figwheel-main (2)
- # fulcro (12)
- # hyperfiddle (10)
- # juxt (3)
- # leiningen (10)
- # nrepl (35)
- # off-topic (34)
- # onyx (3)
- # pathom (6)
- # quil (5)
- # re-frame (29)
- # reitit (6)
- # ring (1)
- # ring-swagger (8)
- # shadow-cljs (37)
- # spacemacs (9)
- # sql (9)
- # tools-deps (24)
- # unrepl (1)
- # vim (1)
@thheller Revisiting that cljfmt
problem with clojure.string
being used without proper require, I found that it happens in rewrite.cljs
: Here: https://github.com/rundis/rewrite-cljs/blob/5ed0980d4fc65ba00780deadb3cf245d742bfeb9/src/rewrite_clj/parser/string.cljs#L39 This is quite a bit more problematic than if it had been in cljfmt itself, because the latter is actively maintained, and PRs pulled, but it is not so with rewrite-cljs
. Is my only option now to use my own version of rewrite-cljs
, or is there something I can tell shadow-cljs that will make it handle this omission? Seeing that it does handle it when I have my lib compiled as a :node-library
, but maybe that is totally accidental depending on if the clojure
module has been required by some other piece of code earlier in the compile cycle? (I have the full stack trace, if that is of any help.)
(I am already using my own fork of cljfmt
, tracking upstream tightly, so it is not the end of the world if I have to fork rewrite-cljs
to patch this, but if it can be avoided, I would rather avoid.)
@pez not sure. right now fork is your only option I think. let me think about it. maybe I can work around it somehow.
Thanks. I have forked and have everything working with the npm-module as I had with the node-library, so I am good right now. 😃
With some luck the PR is small and important enough for the maintainer to stir and pull it in.
Hi @thheller, had you time to think any more about https://github.com/thheller/gatsby-cljs and StaticQuery support there? Thank you!
@holyjak @thheller keep me posted on any efforts re: gatsby I’m a shadow-js newbie and this seems like a good starter project
@thheller: when I build my npm-module using :release
some .js
files are totally empty. Buildling using :compile
works. Is there something that I loose by not using :release
?
@pez they become empty because the closure compiler decides they are unused and eliminates everything
@thheller is there a way to provide build opts to build-report? looking at the source it doesn't seem so
what kind of build opts? its purpose is to show what your release
build looks like so it uses your builds release config
So we use this function to build our release
(defn release
"Build :browser release, with advanced compilation"
([] (release "local"))
([release-flag]
(shadow/release* (-> (config/get-build! :browser)
(assoc ::release-flag release-flag)) {})))
I would like a way to provide that build/release config to build-report to track bundle sizes and such
(inherited this project so some part of the code base are a bit of mystery to me still)
as for the build reports there currently is no option to let you edit the config before compiling
but I could probably add a similar thing so you can modify the the build config similar to release*
hi, sorry for what's probably a simple question, but has anyone used npm fonts with shadow-cljs? like, once i npm install --save some-font
, what's the preferred method for actually using it?