reveal

kenny 2021-11-16T02:34:40.059400Z

Is it possible to send a value to the output panel from the results panel? Is this something that would be a normal reveal interaction?

vlaaad 2021-11-16T08:15:06.059500Z

I wouldn’t say it’s a normal Reveal interaction, why do you want to do something like that? It’s possible, but depends on your setup. If you create a Reveal window yourself, you can just call the function that manages the window to submit values. If you use Reveal as a REPL, usually using tap> to submit values from anywhere is enough

kenny 2021-11-16T14:49:46.060100Z

Hmm. I see. I'm pondering what the right "show test diff" interaction is. I want to rely on reveal's deep-diff support, but I'm not sure where exactly the diff should go.

kenny 2021-11-16T14:50:09.060300Z

What about opening a new window, like Cursive does, with just the diff?

vlaaad 2021-11-16T15:29:28.060500Z

Oh, hmm… What’s currently possible with public APIs is using action-popup so you can use right click to execute some action

vlaaad 2021-11-16T15:31:47.061600Z

I think I could also create a button of sorts that executes action and opens new result panel, so you could use that…

kenny 2021-11-16T15:32:57.061800Z

I discovered the popup-view the other day reading through the source 🙂

kenny 2021-11-16T15:35:05.062200Z

Each level there is a popup-view. What I'm thinking is to allow an action to get attached to each one that is "show diff." It could either: 1) update the result panel to show a deep-diff view 2) open a new window showing a deep-diff view. TBH, I'm not sure how to do either 🙈 Given an object, what reveal view can I use to render it like it would be rendered in the output panel?

vlaaad 2021-11-16T17:28:01.062400Z

This is seriously awesome! It would be great to have this in Reveal. If you want to open source it, I'd be happy to maintain it as a part of Reveal

vlaaad 2021-11-16T17:30:15.062600Z

And I'd be happy to help with the impl..

vlaaad 2021-11-16T17:31:09.062800Z

I wonder how you do current test progress tracking

vlaaad 2021-11-16T17:31:34.063Z

Is it done using some atom and observable-view?

vlaaad 2021-11-16T17:32:50.063200Z

In that case it could have some extra state with currently shown diff, and your view can use that state to show the diff

vlaaad 2021-11-16T19:00:04.063400Z

> Given an object, what reveal view can I use to render it like it would be rendered in the output panel? rx/value-view

👌🏻 1
kenny 2021-11-16T19:10:20.063600Z

Yep! atom+observable-view. I just collect the events and have a single function to interpret the events as the above structure.

kenny 2021-11-16T19:12:42.063900Z

Yeah, I don't really care how it is made available. Native in reveal makes the most sense long term for sure.

kenny 2021-11-16T19:13:36.064100Z

I was thinking I finish the ui in a library, share it for feedback, and then open a pr against reveal to get it added?

vlaaad 2021-11-16T19:19:28.064300Z

sounds good!

kenny 2021-11-16T19:30:22.064500Z

Happy to take your feedback on the cljfx code & ui since I am really new to the whole thing.

vlaaad 2021-11-16T19:33:50.064700Z

sure