Fork me on GitHub
#pathom
<
2020-09-11
>
jimberlage19:09:48

Is there a particular reason why defresolver/defmutation aren't wrapped with #?(:clj) at the moment? It prevents pathom from compiling under shadow-cljs, but I was wondering if there's a reason for doing it this way that I'm missing

souenzzo19:09:34

@jimberlage you can use pathom both on server and client

jimberlage19:09:07

I know - it shouldn't prevent functionality on the server. The other macros are wrapped in #?(:clj), which plays nice with clojurescript. It's only defresolver/defmutation that are unwrapped, which causes compiler errors

jimberlage19:09:29

If the code were updated to do the same for the other macros, pathom would work under shadow-cljs no problem

wilkerlucio19:09:53

@jimberlage hello, can you open a issue for it? or if you like to change and send a PR, welcome as well 🙏

jimberlage19:09:34

I already have a PR open for it, if you want to check it out - https://github.com/wilkerlucio/pathom/pull/172

wilkerlucio19:09:38

:man-facepalming: my bad, checking it now

jimberlage19:09:43

Really appreciate your work on pathom, btw!

🙂 4