This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2020-09-11
Channels
- # announcements (7)
- # aws (52)
- # babashka (16)
- # beginners (49)
- # bristol-clojurians (1)
- # calva (2)
- # chlorine-clover (26)
- # cider (6)
- # clara (1)
- # clj-kondo (79)
- # cljfx (15)
- # clojure (82)
- # clojure-berlin (2)
- # clojure-czech (1)
- # clojure-europe (26)
- # clojure-france (91)
- # clojure-germany (48)
- # clojure-nl (7)
- # clojure-norway (99)
- # clojure-uk (54)
- # clojurescript (18)
- # code-reviews (9)
- # data-science (2)
- # datalog (15)
- # datomic (15)
- # depstar (20)
- # emacs (4)
- # events (1)
- # fulcro (30)
- # funcool (1)
- # graphql (1)
- # helix (5)
- # jobs (6)
- # kaocha (12)
- # leiningen (8)
- # luminus (1)
- # malli (13)
- # off-topic (73)
- # pathom (12)
- # portal (11)
- # portland-or (1)
- # re-frame (10)
- # reagent (1)
- # reitit (44)
- # remote-jobs (1)
- # ring (19)
- # shadow-cljs (64)
- # tools-deps (32)
Is there a particular reason why defresolver/defmutation
aren't wrapped with #?(:clj)
at the moment? It prevents pathom from compiling under shadow-cljs, but I was wondering if there's a reason for doing it this way that I'm missing
@jimberlage you can use pathom both on server and client
I know - it shouldn't prevent functionality on the server. The other macros are wrapped in #?(:clj)
, which plays nice with clojurescript. It's only defresolver/defmutation
that are unwrapped, which causes compiler errors
Where? https://github.com/wilkerlucio/pathom/blob/master/src/com/wsscode/pathom/connect.cljc#L1541
Here's an example of a macro in cljc that works well when compiling under shadow-cljs: https://github.com/wilkerlucio/pathom/blob/2c707bbcad45d37250a89332ae889865ab8498ca/src/com/wsscode/pathom/trace.cljc#L53
If the code were updated to do the same for the other macros, pathom would work under shadow-cljs no problem
@jimberlage hello, can you open a issue for it? or if you like to change and send a PR, welcome as well 🙏
I already have a PR open for it, if you want to check it out - https://github.com/wilkerlucio/pathom/pull/172
:man-facepalming: my bad, checking it now