This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2019-05-13
Channels
- # announcements (34)
- # aws (1)
- # beginners (99)
- # boot (19)
- # calva (26)
- # cider (24)
- # cljdoc (8)
- # cljs-dev (29)
- # clojure (107)
- # clojure-dev (3)
- # clojure-europe (12)
- # clojure-finland (1)
- # clojure-italy (24)
- # clojure-nl (5)
- # clojure-spec (13)
- # clojure-sweden (3)
- # clojure-uk (36)
- # clojurescript (4)
- # community-development (14)
- # cursive (3)
- # data-science (6)
- # datascript (57)
- # figwheel-main (3)
- # fulcro (9)
- # graalvm (11)
- # hoplon (18)
- # jobs (1)
- # jobs-discuss (2)
- # joker (10)
- # leiningen (13)
- # off-topic (23)
- # other-languages (1)
- # pathom (24)
- # pedestal (5)
- # re-frame (6)
- # reagent (45)
- # reitit (3)
- # rewrite-clj (1)
- # spacemacs (2)
- # sql (23)
- # tools-deps (6)
- # vim (5)
@flyboarder thanks for the quick merge!
is there any way we could push a release through? my plan is to submit a PR to hoplon/google-maps upgrading its hoplon/google-loader dependency to a new version that includes my patch, and then use the upgraded hoplon/google-maps, which will allow me to tighten the CSP on the hoplon app i'm securing
i tried to fork hoplon/google-maps and hoplon/google-loader, but ran into all kinds of crazy problems involving hoplon and the classpath. i'm guessing it's because i didn't build hoplon/google-loader correctly, like maybe it requires a specific version of boot and invocation of the hoplon
task in the build pipeline? (the source file is .cljs.hl)
@raywillig maybe you have some context?
this is the error i ran into when i tried to use my forks:
No such namespace: hoplon.google.jsapi.loader, could not locate hoplon/google/jsapi/loader.cljs, hoplon/google/jsapi/loader.cljc, or JavaScript source providing "hoplon.google.jsapi.loader" in file /home/dave/.config/boot/cache/tmp/home/dave/code/geir/eat/-10u6k3/index.f6b82e53a15743339495436bd9ff7926.html.out/hoplon/google/jsapi/maps.cljs
@dave we should fix that, libraries shouldnt use the .cljs.hl files
i also tried pulling the source for google-loader into the google-maps repo, and translating the .cljs.hl into .cljs. that built and ran with no errors, but then my app completely lost its mind and threw a bunch of JS console errors like
core.cljs:717 Uncaught TypeError: elem.addEventListener is not a function
and
Uncaught Error: No protocol method IDeref.-deref defined for type object: [object Event]
maybe because i'm using a newer version of hoplon than the one that was around when google-loader was written@flyboarder that makes perfect sense to me. i'm happy to submit a PR for that actually
Yep, let’s do it!
@dave could you try a rebase
google-loader (2 tasks ready) → git rebase -i origin/master
Successfully rebased and updated refs/heads/cljs-hl-to-cljs.
google-loader (2 tasks ready) → gs
On branch cljs-hl-to-cljs
Your branch is up-to-date with 'daveyarwood/cljs-hl-to-cljs'.
nothing to commit, working directory clean
google-loader (2 tasks ready) → gpf
Everything up-to-date
@flyboarder there we go! it's fixed