hoplon 2019-05-13 | Slack Archive

dave17:05:45

@flyboarder thanks for the quick merge! is there any way we could push a release through? my plan is to submit a PR to hoplon/google-maps upgrading its hoplon/google-loader dependency to a new version that includes my patch, and then use the upgraded hoplon/google-maps, which will allow me to tighten the CSP on the hoplon app i'm securing i tried to fork hoplon/google-maps and hoplon/google-loader, but ran into all kinds of crazy problems involving hoplon and the classpath. i'm guessing it's because i didn't build hoplon/google-loader correctly, like maybe it requires a specific version of boot and invocation of the hoplon task in the build pipeline? (the source file is .cljs.hl) @raywillig maybe you have some context?

dave17:05:29

this is the error i ran into when i tried to use my forks:

No such namespace: hoplon.google.jsapi.loader, could not locate hoplon/google/jsapi/loader.cljs, hoplon/google/jsapi/loader.cljc, or JavaScript source providing "hoplon.google.jsapi.loader" in file /home/dave/.config/boot/cache/tmp/home/dave/code/geir/eat/-10u6k3/index.f6b82e53a15743339495436bd9ff7926.html.out/hoplon/google/jsapi/maps.cljs

flyboarder17:05:44

@dave we should fix that, libraries shouldnt use the .cljs.hl files

dave17:05:57

i also tried pulling the source for google-loader into the google-maps repo, and translating the .cljs.hl into .cljs. that built and ran with no errors, but then my app completely lost its mind and threw a bunch of JS console errors like

core.cljs:717 Uncaught TypeError: elem.addEventListener is not a function

and

Uncaught Error: No protocol method IDeref.-deref defined for type object: [object Event]

maybe because i'm using a newer version of hoplon than the one that was around when google-loader was written

dave17:05:11

@flyboarder that makes perfect sense to me. i'm happy to submit a PR for that actually

dave17:05:16

i've already done the translation

flyboarder17:05:34

Yep, let’s do it!

dave17:05:38

incoming!

flyboarder18:05:40

@dave could you try a rebase

dave18:05:25

sure

dave18:05:44

it was a no-op

dave18:05:58

google-loader (2 tasks ready) → git rebase -i origin/master
Successfully rebased and updated refs/heads/cljs-hl-to-cljs.

google-loader (2 tasks ready) → gs
On branch cljs-hl-to-cljs
Your branch is up-to-date with 'daveyarwood/cljs-hl-to-cljs'.
nothing to commit, working directory clean

google-loader (2 tasks ready) → gpf
Everything up-to-date

dave18:05:13

oh, wait

dave18:05:15

i need to pull origin master

dave18:05:46

there we go, there is a conflict i can resolve

dave18:05:22

@flyboarder there we go! it's fixed

dave18:05:28

argh, hang on

dave18:05:11

ok, NOW it's fixed 🙂

2019-05-13

Channels