Im away from computer now, but I confirmed it multiple times, switched version and back about 3 times, the issue was consistent

the case is after a load to get data and display in a modal

the code works fine on workspaces, but on the real app it was calling the modal with blank props after load

but forcing a root refresh renders correctlu after that

super strange.

so it might something inderect, needs some depth on the query to reproduce, thats my current guess

basically all the optimization does is replace duplicate versions of the default lifecycle methods with a single shared one

maybe its having different closures or something

I wonder if there’s a problem with the hook-up and one isn’t getting installed properly…could corrupt the indexes if so. Hm…closures…guess that’s possible, but I think they only use this

and in this case the main component doest override any lifecycles

(the componente being loaded)

I’ve placed a warning on the FUlcro README for now until we diagnose.

I did notice that @thheller patch no longer clones the React prototype…but that didn’t seem problematic to me…but then I didn’t write that original bit of code. It came from Om Next.

hey. hmm this is odd. goog.object/extend is basically the same as goog.object/clone. It just copies properties from one object to another

and does so for multiple objects

yeah, it looked sane to me

next time might be better not to move things around in source…sure would be nice to see a clean diff.

I had to move it since the new prototype accesses functions in that ns

why wouldn’t declare work?

declare is icky in CLJS since it messes up callsites

unless you manually provide arglists ...

(in upcoming version. not yet releaed)

meh

Things to love and hate in all languages I guess

hmm would love to help track this down though. not sure where to start though

agreed…min repro would be helpful

@wilkerlucio is this in dev or release only or both?

we have some hints: It misbehaves on a targeted refresh. This means it is looking up props by ident to run a targeted query and property patch. This also uses the metadata about UI path embedded in the props.

the issue happens in both dev and release builds

@tony.kay it does use targetted refresh on my example

@wilkerlucio yep..only way a root refresh would work, but not one after a load I could think of. 🙂

ah, sorry I mean the targetted in terms of load, its load with custom :target

I can try making a min repro later

just detected it this morning

that’s probably not relevant. I mean that it is an optimized render, which requires that get-ident works on the component

and that the path metadata isn’t missing

Is the modal coming up while the data is loading? E.g. is this a new UI element that is coming in with a load?

the modal shows immediatly after user click, it opens showing a loading spinner

the spinner shows fine, the problem is after the load is merged

the component gets blank props

if I force a root render right after that (using inspect) it rendes correctly

right…so what happens on refresh is: 1. The optimal render looks up the ident of the compontn to refresh 2. It runs an ident-join query on that component 3. It patches the result of that query onto the tree of old props 4. It re-renders from root, and S.C.U. short-circiuts everything but that path.

(3) requires that it find the correct path…but I can guess that (3) is OK, because otherwise you’d get the old props.

That leads me to believe that get-ident on that component is failing.

any ID weirdness there? E.g. is the ID of the component changing as a result of the load?

no, the id is fixed, the entity is already loaded, its just pulling more data

portals?

yeah, I do have that

but I dont think its it

If you get a chance, you might add some debug statements into the Fulcro source in the default lifecycle methods and see if anything is going wrong.

because I debugged the props of the component that calls the modal, and props are wrong there too

and in the optimal-render, to see where it is screwing up…my guess is the ident is wrong

“the props are wrong there too”…meaning other problems, or just that the ones are missing ?

I need to go, but let me know if you get more info.

it gets a blank map instead of the props its supposed to have (blank or nil, have to check, still afk)

ok, I’ll try to find some time to look more into it later