This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2017-02-21
Channels
- # arachne (1)
- # aws-lambda (50)
- # beginners (10)
- # boot (59)
- # capetown (4)
- # cider (9)
- # cljsjs (27)
- # clojure (249)
- # clojure-berlin (8)
- # clojure-finland (7)
- # clojure-germany (1)
- # clojure-italy (6)
- # clojure-nl (7)
- # clojure-russia (91)
- # clojure-spec (100)
- # clojure-uk (61)
- # clojureremote (2)
- # clojurescript (171)
- # core-async (11)
- # cursive (31)
- # data-science (1)
- # datascript (2)
- # datomic (11)
- # dirac (2)
- # emacs (16)
- # events (1)
- # hoplon (142)
- # juxt (4)
- # lein-figwheel (9)
- # leiningen (10)
- # luminus (7)
- # lumo (44)
- # mount (3)
- # off-topic (150)
- # om (18)
- # onyx (5)
- # perun (12)
- # planck (12)
- # protorepl (13)
- # re-frame (28)
- # reagent (8)
- # ring (1)
- # ring-swagger (10)
- # spacemacs (2)
- # specter (11)
- # sql (14)
- # untangled (99)
- # vim (18)
- # yada (2)
Hey all. I'm trying to create a cljsjs package ( https://github.com/cljsjs/packages/pull/1007 ). However, when trying to minify file for production use I'm getting the following error:
Minifying gun.inc.js
Feb 21, 2017 11:02:26 AM com.google.javascript.jscomp.LoggerErrorManager println
SEVERE: /home/peter/.boot/cache/tmp/home/peter/code/cljs-packages/gun/erw/u2qisy/cljsjs/gun/development/gun.inc.js:676: ERROR - Parse error. IE8 (and below) will parse trailing commas in array and object literals incorrectly. If you are targeting newer versions of JS, set the appropriate language_in option.
lex: ((lex) || (lex))? Gun.is.rel.ify(lex) : lex,
^
Sifting output files...
I'm not really sure what to do. Would someone point me in the right direction.
I have looked at specifying the language_in
option, however literally none of the other cljsjs projects do this. So I'm not sure that it's the correct direction@petr The gun-js repo contains minfied file, that should be used instead of minifying in cljsjs side
Hi @juhoteperi it does indeed. but you'll find that the releases don't yet have that file
oh, but the latest release doesn't have the minified file
well, I'd suggest just leaving minified file out for now
Ah, no need, you don't need to provide the minified file at all, it is optional
Yes, it doesn't need to exist
Normal file will be used for optimized builds if minified file doesn't exist
Interestingly NPM has release 0.6.3
perhaps they are just not tagging releases in github anymore
https://unpkg.com/[email protected]/ you could download the gun.js and gun.min.js from here
unpkg follows the npm versions so using it is perfectly fine, it is used for example by React package
@juhoteperi I didn't know that. I'll use that
@juhoteperi https://github.com/cljsjs/packages/pull/1007 appears to be correct now!
@petr You also generated the externs against the new version?
Okay, I'll merge it once CI is finished
@petr Thank you for the contribution 🙂