Fork me on GitHub
#cljs-dev
<
2023-01-25
>
slipset11:01:39

Another discussion somewhere reminded me of https://clojure.atlassian.net/browse/CLJS-2268 any reason for not merging?

dnolen17:01:03

Just wasn’t aware of it, I’m always happy to look at low hanging fruit - https://github.com/clojure/clojurescript/pull/198

slipset17:01:06

PRs? I’m speachless 🙂

djblue16:01:51

Hi, I'm running into an issue in cljs where I https://clojurians.slack.com/archives/C06MAR553/p1674664302168559?thread_ts=1674584154.207289&amp;cid=C06MAR553 and I'm wondering if it's because they need to be marked as dynamic, similar to how they are in clojure.core?

thheller17:01:57

in which context are you binding them? the REPL automatically binds them

borkdude17:01:02

SCI copies those vars and if you bind non-dynamic vars SCI will throw (conform JVM clojure, but not conform CLJS which only warns)

👍 2
djblue17:01:16

That was so fast, thank you! ❤️

djblue17:01:20

Pulled this down via git deps and it works for me!