cljdoc

eskos 2023-01-25T14:41:45.285869Z

Would it be out of scope to get cljdoc to support https://mermaid.js.org/ similar to https://github.blog/2022-02-14-include-diagrams-markdown-files-mermaid/? I’ve recently fallen in love with ’em… πŸ™‚

πŸ§œβ€β™€οΈ 1
πŸ§œβ€β™‚οΈ 1
🧜 1
lread 2023-01-25T14:50:24.087039Z

I think it is worth considering @suomi.esko. A while back we added https://cljdoc.org/d/org.cljdoc/cljdoc-exerciser/1.0.90/doc/document-tests/asciidoctor-features#_math, it feels kinda sorta like in that realm of features. Anybody else out there want mermaid support in cljdoc?

Cora (she/her) 2023-01-25T16:02:11.377089Z

ooooh mermaid looks fun!

lread 2023-01-25T19:17:49.739559Z

It does, doesn't it? We'd have to take precautions like GitHub has and not allow interactivity.

Sam Ritchie 2023-01-25T21:59:46.600159Z

whoops, I guess cljdoc doesn’t support [this style][target-url] of markdown link: https://cljdoc.org/d/org.mentat/mathbox.cljs/0.1.0/doc/readme

lread 2023-02-01T21:22:45.007359Z

Have taken a peek, seems related to image links only. It might be a bug in flexmark-java which use to render GitHub Flavoured Markdown. Not sure, have asked them about it here: https://github.com/vsch/flexmark-java/issues/551

lread 2023-01-25T22:03:12.301739Z

@sritchie09 huh, didn't know that was an accepted markdown link syntax.

Sam Ritchie 2023-01-25T22:12:33.939819Z

https://daringfireball.net/projects/markdown/syntax#link

Sam Ritchie 2023-01-25T22:12:44.125359Z

lread 2023-01-25T22:13:09.019929Z

Hmm! TIL. Reference links.

lread 2023-01-25T22:18:05.693829Z

I can take a peek @sritchie09... I think we should probably support this syntax.

πŸ™ 2
lread 2023-01-25T22:41:37.795539Z

Raised an issue: https://github.com/cljdoc/cljdoc/issues/743, will take a peek sometime soonish.

eskos 2023-01-27T13:45:19.785759Z

For the curious, this indeed is valid: https://spec.commonmark.org/0.30/#link-label

lread 2023-01-27T16:03:04.881449Z

Thanks @suomi.esko!

Sam Ritchie 2023-01-25T22:03:10.886569Z

is that only a github thing?