cljdoc 2023-01-25 | Slack Archive

eskos14:01:45

Would it be out of scope to get cljdoc to support https://mermaid.js.org/ similar to https://github.blog/2022-02-14-include-diagrams-markdown-files-mermaid/? I’ve recently fallen in love with ’em… 🙂

🧜‍♀️ 2

🧜‍♂️ 2

🧜 2

lread14:01:24

I think it is worth considering @U8SFC8HLP. A while back we added https://cljdoc.org/d/org.cljdoc/cljdoc-exerciser/1.0.90/doc/document-tests/asciidoctor-features#_math, it feels kinda sorta like in that realm of features. Anybody else out there want mermaid support in cljdoc?

Cora (she/her)16:01:11

ooooh mermaid looks fun!

lread19:01:49

It does, doesn't it? We'd have to take precautions like GitHub has and not allow interactivity.

Sam Ritchie21:01:46

whoops, I guess cljdoc doesn’t support [this style][target-url] of markdown link: https://cljdoc.org/d/org.mentat/mathbox.cljs/0.1.0/doc/readme

lread22:01:12

@U017QJZ9M7W huh, didn't know that was an accepted markdown link syntax.

lread22:01:17

The common syntax is described https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#links.

Sam Ritchie22:01:33

https://daringfireball.net/projects/markdown/syntax#link

Sam Ritchie22:01:44

lread22:01:09

Hmm! TIL. Reference links.

lread22:01:05

I can take a peek @U017QJZ9M7W... I think we should probably support this syntax.

🙏 4

lread22:01:37

Raised an issue: https://github.com/cljdoc/cljdoc/issues/743, will take a peek sometime soonish.

eskos13:01:19

For the curious, this indeed is valid: https://spec.commonmark.org/0.30/#link-label

lread16:01:04

Thanks @U8SFC8HLP!

lread21:02:45

Have taken a peek, seems related to image links only. It might be a bug in flexmark-java which use to render GitHub Flavoured Markdown. Not sure, have asked them about it here: https://github.com/vsch/flexmark-java/issues/551

Sam Ritchie22:01:10

is that only a github thing?

2023-01-25

Channels