If I want to use a fork of Clojure with deps, can I exclude the clojure version pulled in from the system deps.edn somehow?

@cfleming If your local deps.edn file has that (local?) Clojure in :deps directly, it should override the system deps anyway?

correct ^^

assuming you have built and installed that fork locally in Maven so that it's artifact id is still org.clojure/clojure

if you want to call it something else (or use as a git or local dep), then no, that is not currently supported

that's not really intentional just kind of a consequence of various assumptions

Yeah, I changed the artifact ID to reduce confusion.

Hmm

top-level exclusions would possibly help with this but not there yet

Ok, I think it would be kind of a pain to use due to… right, the lack of that.

I’ll stick with Maven for now then, thanks!

Actually, if I had the forked jar in a lib dir, and used :deps {org.clojure/clojure {:local/root "lib/clojure-1.10.1.jar"}}, that should work, right?

i.e. deps will assume that the artifact ID is whatever I tell it.

And that will override the official one.

there are some issues with overriding a maven dep with a git / local dep

so I don't think it will work

Ok, thanks. I’ll ditch that idea for now, then.

that one kind of bugs me. I haven't had a chance to look at it yet

part of it is the version comparison across dep types

but on override that shouldn't matter

Hi folks, has anyone successfully used tools.deps w/ git repos on private repositories?

Yes

I'm having issues w/ unknown host key if I use git@... or I need to provide credentials if I use the https form, which I obviously won't do, since I'm not comiting credentials on the repo

Is there any docs on how to get over that?

can you share the error message or more info about your setup and what you're doing?

what os are you on?

have you been through the git stuff at https://clojure.org/reference/deps_and_cli#_procurers ?

https auth is not currently supported so you'll need to use ssh

I'm running from Fedora 30, very basic setup. The error code I get is:

Execution error (JSchException) at com.jcraft.jsch.Session/checkHost (Session.java:805).\nUnknownHostKey: . RSA key fingerprint is .....

(deps/resolve-deps {:deps {'project {:git/url ":repo"
                                             :sha "commit-sha"}}}
                       {})

I'm running the repl from a session where I've added the keys to ssh-agent, so I assume this step is done.

looks like same as https://clojure.atlassian.net/browse/TDEPS-104

did you add the host to your .ssh/known_hosts ?

there's a workaround described at https://codehopper.nl/2018/09/27/clojure-gitlab-deps/

Hum... I think I know what could be the issue.

I'm using ED25519 instead of RSA for gitlab.

ssh-keyscan -t rsa,ed25519 >> ~/.ssh/known_hosts

that will seed UnknownHostKeys ^ into your config

ED25519 on the user identity file is fine (when using an agent) @ingvij the error you're pasting is an rsa host key, a different kind of key

I see. Fine then, I'll try both approaches and I'll post the results back here.

both?

ssh-keyscan and the link @alexmiller posted

the article @alexmiller posted seems to use the same exact thing I'm describing

ahh, sorry. I hadn't read the article yet

since clojure deps.edn is not terminal interactive, the .ssh/known_hosts file needs the host key

Right, that makes sense.

(but this approach is a bit insecure because no one is validating the fingerprints...)

(then again most people type Yes anyways when ssh prompts you..)

Should work fine as a workaround I suppose.

That worked for checking the dependency, but I'm getting a MetadataNotFoundException now. I'll double-check everything, specially the dependency itself. Thanks for the help @ghadi and @alexmiller.

if you can share more info, might have some idea what that is, but I don't even know what layer of the stack it's from

just in general, providing information at the beginning lets people help you more efficiently, and we're all doing this for free, in spare time

Execution error (MetadataNotFoundException) at org.eclipse.aether.internal.impl.DefaultMetadataResolver/resolve (DefaultMetadataResolver.java:233).\nCould not find metadata org.clojure:clojure/maven-metadata.xml in local (/home/hkupty/.m2/repository)

org.clojure:clojure/maven-metadata.xml looks weird

maybe bad format in your deps.edn?

org.clojure:clojure when should be org.clojure/clojure maybe?

I checked the dependency, it's clojure version was RELEASE as it comes from default when you bootstrap a project w/ https://github.com/seancorfield/clj-new

boo

you should choose an explicit version for clojure

@alexmiller maybe -Sresolve can rewrite symbolic maven things, too

I know. this is still on very initial stages, just testing really..

That's why I didn't care too much about it. Just pinned the version.

re RELEASE, agreed, bleh

RELEASE is not officially supported in deps.edn

I've let it continue to work as it's sometimes a good hack, but shouldn't be enshrining it

-Sresolve is going to go away (move into an external tool)

I moved past that error, now yet another one bothering me. A dependency of a dependency is not being resolved, whereas if I run clj on the library I'm trying to import, it works fine:

Syntax error (ExceptionInfo) compiling at (cli/ops.clj:5:1).\nUnable to resolve io.grpc/grpc-core version: [1.17.1]

(deps/resolve-deps {:deps {'io.etcd/jetcd-core {:mvn/version "0.3.0"}}}
                   {})

I don't want to keep you involved in the debugging unless you want to, I just keep posting since I think those might be relevant. I'd understand if you'd rather want me to open an issue.

which, btw, I'll do for clj-new so new projects are not created w/ RELEASE on clojure version.

that is a syntax error, not related to deps at all

I would dig in to cli/ops.clj on the given line number, likely something isn't being quoted correctly

In light of continued complaints about the use of "RELEASE" in projects created by clj-new ... seancorfield/clj-new {:mvn/version "0.7.7"} pins these to 1.10.1 (for Clojure) and 0.10.0-RC1 (for test.check). You're welcome 🙂

Bear in mind that lein new, boot new, and clj-new all look for templates themselves (on Clojars/Central) using "RELEASE" under the hood unless you specify a template version to use (which almost no one does).

thanks @seancorfield

This is not a critical question in any way, but was curious whether folks had any recommendations on creating a deps.edn file for a library that has Clojure-specific and ClojureScript-specific flavors in the same git repo, e.g. core.rrb-vector is the one I have in mind. One thought: create a deps.edn that has almost 0 dependencies when no aliases are specified, and has a :clj alias for Clojure dependencies/paths, and a :cljs alias for ClojureScript dependencies/paths. Second thought: Two separate deps.edn files, except there is only one root directory file named deps.edn available.

Third thought: two separate git repos, one for each variant?