Hi. Can I use :compiler-options :output-to to specify a relative path for the production build script with :target :browser ?

I realize I can just move the file with a separate shell command but it would be much neater to be able to specify the file name

instead of having to use the namespace (which means atm I get main.js, but I guess that will change too)

@ashnur can you use :release {:output-dir "build/js"}? I only learned of this option recently myself.

yeah you can just configure a different output-dir for release builds, see https://shadow-cljs.github.io/docs/UsersGuide.html#_release_specific_vs_development_configuration

@chris358 @thheller does :output-dir change the outputted file's NAME?

if so, it's quite terribly named

no, actually, I get an error that the path is not a directory

no. you control that name via :modules {:main ...}

:main becomes main.js

I don't follow

:output-dir specifies which directory the files are written to

right, but I am asking how to have a specific filename for the production build

'path' for me means 'dir' + 'filename', maybe terminology discrepancy

why does it have to be different for your production build?

because that is my goal for today

at the moment 🙂

weird goal ...

the way this works in shadow-cljs is that you specify an :output-dir

why so judgmental? :D

all files are written into that directory

so I can't change from shadowcljs this

it should be exclusively for files compiled by shadow-cljs

each module creates one file, named by the module name

that is the assumption

thanks, i will just use another process externally to move the files to their appropriate place with their appropriate name then

it is hardcoded

you cannot change it

I thought I can use shadowcljs for build stuff

not sure what you mean by appropriate

intended

final

useful

if you want main-production.js or whatever it is advised to use a different directory for ALL files

so /js/compiled/main.js or /js/dev/main.js or whatever

sure, that's not a problem, but I still can't change the filename, just because other files are there too

I really do not understand your problem?

as it stand, I still need something else externally to find the file and rename it, so I need additional tooling

you can change the name by changing the module name?

:modules {:main ...} becomes main.js. :modules {:foo ...} becomes foo.js

but that's the module name, not the filename

THAT IS THE FILENAME!

sorry, I don't want to frustrate you : (

clearly I misunderstand something, it's not my intent to cause trouble

I explained as best I can. It is a hardcoded assumption that cannot be changed.

This is what I took that 'hardcoded, can't be changed -> filename must be the same as the namespace'

Is this not correct?

and it's not

@thheller you explained well, but I misunderstood, {:output-dir "../dist" :modules {:new-filename {:init-fn app.core/main}}} creates ../dist/new-filename.js I am sorry for being thick headed at first

now my only worry is that shadowcljs might overwrite something, but "luckily" production build assets are also in git so at least it's visible if it happens 🙂

as I said it is recommended that shadow-cljs owns that directory completely

so use :output-dir "../dist/js" or so

but I can't do that

it would mean that I have to rewrite gazzillionn legacy stuff in a huge django project that's over 8 years old that uses dist to publish everything

"everything" but not subdirectories?

I am trying to sneak in something on the back door, if I have to work on this 2 weeks just to get the paths right (you can see how slow I am, I am not exxargerating), it will not work : )

ok

no, I mean, there are already paths pointing to this filename I am writing

of course it would get published in a subdirectory too, you are entirely correct in everything you said 🙂

yeah as soon as you said legacy stuff I understood 😛

thanks, next time I will lead with that then : )

in like 8 years since I've been trying to use clojure(script) for work, this is the first time I think I will succeed, it's thrilling

I'm switching a cljs react-native project from lein/clj/clj-rn to shadow-cljs. I got the dev and build working but I'm struggling with the tests. Previously the react-native libs were mocked by importing dependencies in a namespace. That namespace would be at different source path, one for the project code with requires, and one for the test with mocks of the functions that are called in tests. Now with shadow-cljs since the imports are made directly in the require I'm not sure how to proceed to mock these imports

not sure I understand the setup, will need to see some code I'm afraid 😛

sure do you want the old setup or the new one?\

this is the old project.cljs https://github.com/status-im/status-react/blob/develop/project.clj with mocked dependencies https://github.com/status-im/status-react/blob/develop/test/cljs/status_im/react_native/js_dependencies.cljs and test runner https://github.com/status-im/status-react/blob/develop/test/cljs/status_im/test/runner.cljs

so the tests are running completely without any react-native involvement?

yes they are just meant to test the logic and react-native effects are mocked

most of the time they don't even happen because most tests are testing the map of effects outputed by events without applying them (so no effects occur)

so how does the code look now?

does this ns still exist? https://github.com/status-im/status-react/blob/develop/test/cljs/status_im/react_native/js_dependencies.cljs

or do the sources access the react-native deps directly?

yeah they access the deps directly from require

this ns was the mock, in any case I couldn't use the same method with shadow since you can't define different src-path for different builds, which was how it worked

thats not entirely true

shadow-cljs allows aliasing namespaces

https://github.com/status-im/status-react/blob/develop/react-native/src/mobile/status_im/react_native/js_dependencies.cljs

that is the original namespace

so you can use the mocked ns and call it (ns status-im.react-native.js-dependencies-mock)

then in your build config use :build-options {:ns-aliases {status-im.react-native.js-dependencies status-im.react-native.js-dependencies-mock}}

that would make every namespace that references the js-dependencies use the mock instead

if each ns has the requires directly you can use the :resolve option to mock things https://shadow-cljs.github.io/docs/UsersGuide.html#js-resolve

or use :js-options {:js-provide :require} (assuming its a :browser) build and provide your own require fn that returns the mocks

so something like <script>window.require = function(name) { if (name == "foo") { return {} } else ... }; </script>

can of course write that in CLJS also

plenty of ways to mess with this 😛

ideally I'd like to keep the requires directly in the ns declaration "shadow style", and keep the tests as vanilla cljs as possible so I'll look at js-options and js-resolve

resolve will be rather verbose and since you are likely going to override all of them it might be better to just create a custom require fn

its typically meant for single rewrites like react -> preact or so

Hi! I’m having an issue when using schema-generators along with shadow-cljs. If I use clojurescript version 1.10.520 with shadow <= 2.8.83 everything works. If I bump clojurescript to version 1.10.597, or keep the version 1.10.520 but bump shadow-cljs to 2.8.84 I start to get the error Couldn't satisfy such-that predicate after 10 tries when trying to generate a schema. I’m asking for help here because if I use clojurescript version 1.10.597 and the cljs.build.api everything works fine. Do you have any clue about what may be happening? I thought it could a dependecy issue, but I compared both dependency trees (printed with lein deps :tree) and the tree using version 2.8.83 and 2.8.84 are identical (with exclusions loom pathom and core.async). Maybe I’m missing something when checking the dependencies. I have a sample project reproducing the issue at: https://github.com/felipethome/sg-issue

make sure you get these versions

[com.google.javascript/closure-compiler-unshaded "v20191027"]

   [org.clojure/google-closure-library "0.0-20191016-6ae1f72f"]
   [org.clojure/google-closure-library-third-party "0.0-20191016-6ae1f72f"]

looks like you don't have those

Still the same problem here

sorry don't have time to look at that further

try without lein

Unfortunately I can’t stop using lein at this moment. Thank you! I will try to investigate more

Is it possible to specify different configs before build for

shadow-cljs watch app

shadow-cljs release app

https://shadow-cljs.github.io/docs/UsersGuide.html#_release_specific_vs_development_configuration

So you do it directly in shadow-cljs.edn?

That’s a little bit to awesome for my taste Mr @thheller 🙏 You sir are a legend, and so is shadow-cljs

How do I access the config variables inside my cljs files?

https://shadow-cljs.github.io/docs/UsersGuide.html#closure-defines

Boom 💣

thanks

i have not been this happy for months

everything just works