Those grays are just different enough that it hurts 😆, need to add a clerk theme

Just lovely ahahahaha 🙏

hey Chris, pretty funny. Curious what made you build this, just for fun or do you have an actual use case?

Portal recently https://github.com/djblue/portal/releases/tag/0.30.0 for https://calva.io/notebooks/ as a renderer, which got me thinking about what integrating portal into clerk would look like. My main motivation is to author notebooks to document viewers with live examples. These notebooks should work at the clojure repl, in a calva notebook and in a clerk notebook since the common format is a clojure file.

It actually was pretty easy getting it working in clerk 💯

This version of a portal viewer wouldn't work with the static site generation, but that would be easy to add via the https://github.com/djblue/portal/blob/master/doc/guides/standalone.md.

My other main goal is allowing users to utilize portal in their preferred context

https://clojurians.slack.com/archives/C0185BFLLSE/p1660889269813399 is what the calva notebook looks like

standalone portal looks neat

need to take a closer look at the Calva integration

ah I see you’re embedding the iframe

I guess it should be possible to embed it in the same context if you take over ClojureScript compilation and make a bundle with Clerk’s and Portals CLJS code in it

> My main motivation is to author notebooks to document viewers with live examples. Embedding them in the same context should get the static build working (in case you want to publish those notebooks 👆 via Clerk’s static publishing)

👍 for the light theme! 😜

Is the spec for the data too restrictive?

Not everyone uses timbre Assuming we don't want to introduce into source code something new outside of Clojure core, how can portal hitch itself onto it? How about injecting an inline metadata to tap, then massaging the tap target based on metadata attached to the form?

The spec is way too restrictive and not discoverable

Imagine a ^:portal/log metadata which would build the correct message

I am working on viewer level docs and am very open to loosening up the spec

The logging spec isn't based on timbre. The docs have a mapping from timbre to the log viewer.

yeah, but the only example is very tied to timbre

https://github.com/djblue/portal/blob/master/src/portal/console.cljc is the original place where I came up with the schema

https://github.com/seancorfield/dot-clojure/blob/develop/dev.clj#L86-L116 is how you can do it with tools logging, which I'm hoping to add to the docs soon

Was thinking about something like (alter-meta! #'tap install-viewers-meta)

and build the correct tap object on portal's side instead of user's side

according to the meta on the target

Wait, so what does the data look like that lives on the user's side?

normal, a user would just (tap> x)

the inliner would use metadata provided by the compiler to build the required data

I guess I'm confused about what this inliner would look like outside of a clojure macro

Ohh, I think I understand what you mean

I would prefer people use portal.console instead of monkey patching a clojure core fn

However, providing people a guide to do it would be reasonable 👌

Another option I've been thinking about to make it easier to use portal.console is adding a reader tag, something like #portal/log .

It could do one of two thing. It could produce the log map which can then be sent to tap> or it could tap> the map itself, not sure which is better :thinking_face:

Data > effects

A reader tag would be great

What parts of the spec were causing issues / annoying?

Date, level

Was it easy to satisfy the requirements after you found the spec?

No, date's pred being JavaScript was opaque for me

If you saw (s/def ::time inst?) in the docs, would you have know a java date would also work from clj land?

Not sure why I have a custom one in the viewer, but i think inst? is the correct predicate

That's a Clojure problem that it doesn't tell me which types satisfy inst?

Why Date and not Instant?

And, iirc, I had to send a long eventually, not an instant

also, if we're just tracing values chronologically, I find I don't have anything to do with the log level. I care about time and place, less about level

Also, leiningen instructions would be beneficial for legacy users 🙂

I'm surprised the long worked :thinking_face:

What type of instructions? Like in the readme on how to start the project?

yes, how to add it to a project or to the ~/.lein/profiles.clj

We tend to assume everyone knows their tooling well, but it turns out most people are there for a job not because if they couldn't do Clojure they'd quit and go be a carpenter :man-shrugging:

Would you mind putting a PR for the lein stuff? Not very familiar with the best way to use it.

Also, thanks for sharing all this feedback 🙏

Gladly and with pleasure. Least I can do 🙂

I added https://github.com/djblue/portal/blob/master/doc/guides/portal-console.md#spec for now to help people in the future who run into these issues 👌