Fork me on GitHub
#portal
<
2021-11-09
>
Pragyan Tripathi11:11:38

I use VSCode and SSH to a local vagrant box to do the development. In my current setup executing (def p (p/open {:launcher :vs-code})) opens an empty tab as in the screenshot. Any resolution for that?

djblue16:11:55

My best guess is that the vagrant box isn't accessible from localhost. You can try providing :portal.launcher/host with the ip of the vagrant box and see if that works. Another option is providing :portal.launcher/port and adding a port mapping.

Pragyan Tripathi05:11:29

Awesome.

(def p (p/open {:launcher :vs-code
                  :portal.launcher/port 3434}))
with the port mapping it works. Thanks a lot.

awesome 1
markaddleman16:11:20

Feedback on the IntelliJ plugin: • First, holy moley! Congrats on a tool that greatly improves my REPL experience! • It seems that Portal captures keystrokes that it shouldn't. For example, if I have focused on the Portal viewer and then I click shift-shift to open the IntelliJ global navigation popup, some keystrokes (I assume keystrokes that the Portal browser captures) are dropped. A couple of keys keystrokes are e and l

❤️ 1
djblue17:11:24

Interesting, I'll have to look into how the shortcut system in portal interacts with the parent intellij window :thinking_face:

wilkerlucio19:11:57

@djblue hello, I'm having a lot of fun with portal on intellij! I loved the custom styles that integrate nicely with IntelliJ, but I notice if you have a portal open already, and open it again (in case of a REPL restart for example) the second time it opens without the custom styles (and end up being quite big)

wilkerlucio19:11:37

after that I have to close the project window and open again to get the "IntelliJ style" back again

djblue20:11:26

Looks to be a data race between passing options to the chrome window. I think it's a bigger problem for the production bundle since it loads much faster 👌

djblue20:11:01

I think if I switch to session storage it won't be a problem 👌

seancorfield23:11:25

@djblue Q about portal.console: If I wanted to tap> something that Portal would treat as a log expression, what exactly is it that triggers that? I've tried to tap> a hash map that looks like what portal.console/capture does but Portal just displays it as a map.

djblue23:11:49

It's a bit restrictive currently and I'm down to tweak it a bit

seancorfield23:11:05

OK, got it working. I think I was missing something "obvious" in my setup.

awesome 1
seancorfield23:11:10

I'm playing with some code to install tap> into tools.logging so while I'm developing, all my code will write those log messages into Portal, but since that's all macros you lose some data (line/column, since you can onto wire into the log* function inside tools.logging).

seancorfield23:11:31

I was originally thinking of writing a tap> Appender but that's a lot of messing about...

djblue00:11:57

Nice, would be really nice if you got line/column info :thinking_face:

djblue02:11:26

Dang, now that is legit! Does it work well with goto-definition?

seancorfield02:11:55

Not sure how to use/test that?

djblue02:11:55

Within portal, it should popup as a command when a log entry is selected or you can try the shortcut g d

seancorfield02:11:03

No, presumably because :file isn't a sensible value?

djblue02:11:47

I wonder if the resolver could try to find a file for the ns :thinking_face:

seancorfield02:11:18

I'm trying .getFileName on the stack frame now...

seancorfield02:11:40

Hmm, it seems to just return the filename with no full path... I'll play with it some more tomorrow...

👍 1
seancorfield02:11:18

Ah, it does for some logging but not all, it seems.

seancorfield02:11:50

In the latest Portal in VS Code, I don't seem to be tab into the main content section, BTW.

seancorfield02:11:51

I have to actually click into the view now, whereas I used to just be able to TAB into it.

djblue02:11:27

After you tab, do you use the arrow keys?

djblue02:11:01

I had some issues with multi-select and tab, I may have broken something :thinking_face:

seancorfield02:11:51

I can't press / and have it focus on filter either.

seancorfield02:11:58

When I switch to the Portal tab, the first TAB takes me to the Clear button, TAB then goes to the viewer drop-down, TAB then goes to the command palette.

seancorfield02:11:27

Even selecting focus-filter from the command palette does nothing unless I've clicked into the content section now.

seancorfield02:11:06

Confirmed it works on 0.16.3 but broken in 0.17.0

djblue02:11:35

Sorry about that, will see about fixing it soon

djblue02:11:22

Thanks for reporting these issues :thumbsup:

seancorfield03:11:23

(we're watching TV now but I just wanted to say that working with Portal in VS Code is amazing and makes my life -- both work and OSS -- so much better... I didn't want to leave things with just "grumbles" and bug reports)

❤️ 2
djblue03:11:22

No worries, I really value your feedback and appreciate your in-depth issue reports!