My best guess is that the vagrant box isn't accessible from localhost. You can try providing :portal.launcher/host with the ip of the vagrant box and see if that works. Another option is providing :portal.launcher/port and adding a port mapping.

Awesome.

(def p (p/open {:launcher :vs-code
                  :portal.launcher/port 3434}))

Interesting, I'll have to look into how the shortcut system in portal interacts with the parent intellij window :thinking_face:

after that I have to close the project window and open again to get the "IntelliJ style" back again

Looks to be a data race between passing options to the chrome window. I think it's a bigger problem for the production bundle since it loads much faster 👌

I think if I switch to session storage it won't be a problem 👌

https://github.com/djblue/portal/commit/427f5a1e957b9be9ead6cd15ec95348f30b028fa should fix it

This https://github.com/djblue/portal/blob/master/src/portal/ui/viewer/log.cljs#L21-L27 is the current decision point.

It's a bit restrictive currently and I'm down to tweak it a bit

OK, got it working. I think I was missing something "obvious" in my setup.

I'm playing with some code to install tap> into tools.logging so while I'm developing, all my code will write those log messages into Portal, but since that's all macros you lose some data (line/column, since you can onto wire into the log* function inside tools.logging).

I was originally thinking of writing a tap> Appender but that's a lot of messing about...

https://github.com/seancorfield/dot-clojure/commit/b4f2639f8a52eec8cf8c6dffa00e5dc6b0cb4b96 🙂

Nice, would be really nice if you got line/column info :thinking_face:

Done: https://github.com/seancorfield/dot-clojure/commit/39609d591c9846d6cf992e381520b032cf2014de

Dang, now that is legit! Does it work well with goto-definition?

Not sure how to use/test that?

Within portal, it should popup as a command when a log entry is selected or you can try the shortcut g d

No, presumably because :file isn't a sensible value?

I wonder if the resolver could try to find a file for the ns :thinking_face:

https://github.com/djblue/portal/blob/master/src/portal/runtime/jvm/editor.cljc#L22-L31 is the existing code if you are interested

I'm trying .getFileName on the stack frame now...

Hmm, it seems to just return the filename with no full path... I'll play with it some more tomorrow...

Ah, it does for some logging but not all, it seems.

In the latest Portal in VS Code, I don't seem to be tab into the main content section, BTW.

I have to actually click into the view now, whereas I used to just be able to TAB into it.

After you tab, do you use the arrow keys?

I had some issues with multi-select and tab, I may have broken something :thinking_face:

I can't press / and have it focus on filter either.

When I switch to the Portal tab, the first TAB takes me to the Clear button, TAB then goes to the viewer drop-down, TAB then goes to the command palette.

Even selecting focus-filter from the command palette does nothing unless I've clicked into the content section now.

Confirmed it works on 0.16.3 but broken in 0.17.0

Sorry about that, will see about fixing it soon

Gotta run.

Thanks for reporting these issues :thumbsup:

(we're watching TV now but I just wanted to say that working with Portal in VS Code is amazing and makes my life -- both work and OSS -- so much better... I didn't want to leave things with just "grumbles" and bug reports)

No worries, I really value your feedback and appreciate your in-depth issue reports!