This plus some jump to source magic would be awesome!

I haven't considered what a client side extension api would look like, would be interested in your ideas.

@U2845S9KL I would checkout the portal.runtime.jvm.editor/goto-definition command, or the g d shortcut 🙌

It should work in intellij 💯

Should work with strings, files, namespaces, symbols and maps generated by https://github.com/djblue/portal/blob/master/src/portal/console.cljc#L20-L28

@U1G869VNV sorry, missed the responses here. about the API, I think an initial thing could be aroudn the currenct Hiccup renderer, since it allows some arbitrary HTML, what I'm missing at this point is how, from inside the hiccup also re-use the renderers available from Portal, maybe there is a way to make them accessible from the hiccup, maybe something like:

(tap> ^{:portal.viewer/default :portal.viewer/hiccup} 
  [:div "custom thing here" [:portal.viewer/inspector {:complex :data-structure}]])

ups, actually, it already works 😄

this is the code for it:

(defn portal-logger []
  (fn [{::l/keys [event level line column timestamp namespace] :as log}]
    (tap>
      {:level  (l/level-unqualified-kw level)
       :result (with-meta
                 [:div
                  [:portal.viewer/inspector event]
                  [:portal.viewer/inspector (dissoc log ::l/event ::l/level ::l/line ::l/column ::l/timestamp ::l/namespace)]]
                 {:portal.viewer/default :portal.viewer/hiccup})
       :ns     'some.ns
       :line   line
       :column column
       :time   timestamp})))

Won't get a chance to try this until tomorrow but "thank you!"

Installed the new IJ plugin and updated library and now when passing in {:launcher :intellij} it's not starting up in the tool window now. I'll try a restart in case to confirm...

Ignore me. The restart did it. It's late; maybe I just forgot to restart after installing the new plugin.

But, it still seems to have the problem @U066U8JQJ reported earlier with styling.

I think you might also need to bump the version running in process 👌

The plugin only acts as a way to launch the UI hosted by your clojure process in your editor.

I'll double check tomorrow. Thought I had bumped that as well, though

Steps to reproduce (for me, running v21.2.3 Ultimate on JDK 11 on Big Sur) 1. Start REPL with IJ (NREPL, using the Cursive/IJ standard launching process) 2. Start Portal 3. Stop REPL 4. Restart REPL 5. Start Portal On restart, the theming is going back to Portal defaults.

Can you verify that if you call open again after step 5 it goes back to the correct theme?

It did go back to correct theming if I open a second time.

Thanks for verifying! Will see what I can do to fix the race :thumbsup:

Confirmed this fixes the VS Code focus issue -- thank you!

I think the / shortcut still has a few edge cases, but it should work a little better. I need to rethink implementation.

BTW, those arrow characters are still unrenderable on my old Mac - I wasn't sure whether you were planning to change them?

(and the four history ones as well)

I do plan on fixing the issue, just haven't prioritized it yet :thumbsup:

https://github.com/djblue/portal/commit/1f1049eb488b8640ab04f1222299aac091e8f76e should fix it. Just switched to using icons so I don't have to worry about fonts 😆

Thanks for the the experimental remote mode :)

Interesting, haven't seen this issue before :thinking_face:

btw, I leave these buttons hidden and only show them when I press cmd twice

I will try to switch themes to see if it still happens (I use the Material theme in intellij)

Are the buttons hidden if you hit the button on the bottom left corner?

do you mean bottom right? If I click on the repl button they continue to be hidden

This button

sorry,

Nope, if I click on that button they will show up

btw, changed my theme to darcula just to be sure it wasn’t the Material theme

I would try resizing the tool window real quick. I wonder if there is a bug related to resize for https://plugins.jetbrains.com/docs/intellij/jcef.html

the resizing behavior is very different between the repl and the portal window. when resizing the window, for portal appears a white background, while the repl is more smooth the buttons also show up for a moment during resize

Is cmd+cmd a custom shortcut? If so, what is it calling?

I can’t find this in keymap, but it is not custom: https://youtrack.jetbrains.com/issue/IDEA-203999

This is the only resource I found talking about this shortcut though. I don’t remember how I learned it 😅

This is a very low priority thing, if you don’t want to pursue this anymore it is fine for me! Thank you for the attention I agree with you it looks more as a bug on intellij side than on Portal

I might look more into it after I get some higher priority items done. If you are feeling adventurous, you can run the plugin from the https://github.com/djblue/portal/tree/master/extension-intellij directory from intellij. You can even enable a https://github.com/djblue/portal/blob/master/extension-intellij/build.gradle#L27-L28 server into intellij for some repl driven development 🙌

Thanks again for raising this issue :thumbsup: