Fork me on GitHub
Slack Archive

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

2023-10-11

Channels

#polylith
<
2023-10-11
>
lread15:10:30

Doc review question: In the current https://github.com/polyfy/polylith/blame/6144c816d813ff891e557592542b70262a85b435/doc/build.adoc#L34 doc, I see @seancorfield's https://github.com/seancorfield/build-uber-log4j2-handler is shown as a dep in a code block that is part of the docs' ongoing poly tutorial. I've learned the purpose of this lib (interesting!), but I am guessing it is not strictly necessary for the poly tutorial. But I also see the dep won't hurt anything, and maybe it is a good general safeguard? If this dep is part of some poly best practices that I am not yet aware of, I could add a wee note of explanation. If not, I could remove it to simplify the example.

seancorfield16:10:24

It's one of those things that if you need it but don't have it, very weird things can happen with log4j2 -- but you're right that a lot of app can get away with not needing it. It could (should?) probably be removed from the Polylith docs and I should probably add a section to the http://clojure-doc.org cookbook for tools.build about it. The reason it's there: it was included automatically by my build-clj wrapper which Polylith used to used so I just carried it over into the poly docs when I rewrote them to use bare tools.build. I don't even know if poly depends on anything that uses log4j2...

lread18:10:43

Thanks, @seancorfield, that clears things up for me!

lread19:10:39

BTW, not being familiar with build-uber-log4j2-handler or Log4j2Plugins.dat, it was not immediately clear to me what problem it solved. While I'm in documenting mode, I could PR a few more words in its README if you think that would be helpful.