Fork me on GitHub
#lsp
<
2022-11-02
>
ericdallo16:11:32

Anyone see any problems dropping support for JDK8 on clojure-lsp?

ericdallo16:11:06

I can only see issues for people that use lein-clojure-lsp or clojure-lsp via API in projects using JDK8 yet

borkdude16:11:17

I would be totally fine with it... #C035GRLJEP8 is also considering it. GraalVM will drop support from 23.0.0

jacob.maine16:11:30

We needed a bug fix in promesa relatively recently. Hopefully there won't be any more bugs soon, but it'd be worrisome to be stuck at an old version. So, my vote would be to drop jdk8 support too. Interested to hear from lein-clojure-lsp users though

šŸ‘ 1
borkdude16:11:20

promesa is a small lib so worst case you could fork it temporarily

šŸ‘ 1
ericdallo16:11:08

yeah, Nubank is a heavy user of lein-clojure-lsp and it changed to JDK11/15 only a year ago or so, so I wonder if there is any other heavy users of lein-clojure-lsp using jdk8 yet

ericdallo16:11:46

well, I don't think we should be stuck because of one company or other though, but it'd be nice to know that before

borkdude16:11:58

shadow also dropped support for 8. I think we're in good company

borkdude16:11:19

why would you like to drop support btw?

ericdallo16:11:52

ā€¢ It's tricky to keep supporting jdk8, there are few hard code to maintain on clojure-lsp that use specific classes only to have jdk8 support, parsing uris for example ā€¢ Upstream are starting to drop like promesa, we could fork it but we could have soon any other upstream doing the same ā€¢ CI is a little bit slower on jdk8, that would be a minor nice to have

borkdude16:11:27

good reasons imo

borkdude16:11:45

oh btw, graalvm will drop support for 11 I meant, they have long dropped support for 8

ericdallo16:11:49

Yeah, but we are safe on that as only affects native binary, not lein-clojure-lsp or any JVM stuff

borkdude16:11:40

we could even start using virtual threads in the binary on jdk19 :P

ericdallo17:11:56

Yeah, looking forward to that!

seancorfield18:11:51

State of Clojure 2022 https://clojure.org/news/2022/06/02/state-of-clojure-2022#_working_with_clojure -- still quite a lot of JDK 8 usage there but it that was nearly a year ago. We're on 18 in production and 19 in dev, just waiting for a few things to officially support 19 in production before we upgrade... and start taking advantage of vthreads šŸ™‚ (New Relic just released their JDK 19 support and we have that in QA).

šŸ‘ 2
borkdude19:11:18

A lot of those JVM8 users might still only be using the clojure-lsp native though

šŸ‘ 1