there is lsp-ui-doc-glance I think

or lsp-ui-doc-show

you need lsp-ui package though

roger that. thanks.

so i think it’s doing that on highlight, but im not getting the actual clojure docs

are you using latest clojure-lsp, I included a hot fix yesterday

i upgraded the cask today

brew upgrade clojure-lsp/brew/clojure-lsp-native

if that’s what you mean

but i did see clojure-lsp in brew, so perhaps that’s the right one to use these days?

no, the native one is the correct, whats your clojure-lsp --version ?

clojure-lsp 2021.10.20-16.49.47
clj-kondo 2021.10.20-SNAPSHOT

looks like it’s working now 🤷

although, it doesn’t show the whole Examples section, it cuts off

yeah, the hover via lsp-ui-doc is quite tricky like vscode

I use doom-emacs, and K shows the docs as eldoc buffer and works perfectly

I'm not sure how to achieve that without doom-emacs though :/

what action would one be seeing this under? is this from textDocument/signatureHelp ? textDocument/documentSymbol?

in nvim using nvim-lsp, so trying to figure out which call I should be looking for the feature under

neither, it's textDocument/hover

awesome, will look for that new behavior in a bit

Thank you! The way it works is: when server starts we async request clojuredocs and cache all available docs, then when you hover over a symbol and request clojure-lsp docs about it, clojure-lsp merge the docs from clj-kondo that already exists with docs + examples + notes + see-alsos from the clojuredocs cache if any available

so, if the symbol you request contains on http://clojuredocs.org then it should be available on clojure-lsp as well :)

This is effin rad!

Does it work in Calva already?

yep!

that's the magic of LSP ✨ 😛

but I don't see it there either 😒

I tested with calva when inplementing @U04V15CAJ

@U04V15CAJ what's your clojure-lsp --version?

does it contains the last fix I did about the native image missing protocol?

doesn't calva use the latest if you fill in latest?

yep

when I type (inc 1) and hover inc, should it show me the docs for inc?

yes, could you check the clojure-lsp log file?

it should print a refreshed clojuredocs blablabla when starting

I'll reboot calva just to be sure

is clojure-lsp correctly connected? it's not even outputing the clj-kondo doc information

it should print signature from kondo and doc as well

> clojure-lsp version used: 2021.10.20-16.49.47

well I don't see anything. does it matter that I'm in a .cljs file?

nope, same thing in a .clj file

hum, inc in a cljs buffer returns this: so clojuredocs not working for cljs?

I don't get anything in a .clj buffer either

could you test on emacs?

no, on emacs I have to install other things that don't work

alright

I never got it to work there

I mean

does rename and other lsp features work?

yes navigation works

could you test rename (`<F2>` AFAIK) as it uses source-paths from clojure-lsp

hmm, that didn't work

the docs not showing even clj-kondo singature + docs it's already weird

oh so it's a project configuration error probably

I don't have a deps.edn

because nbb :)

clojure-lsp was not correctly started on the correct project-root or something

oh, maybe that's the issue

I will create one

actually, I think we could make clojure-lsp hover work even with projects that the classpath scan failed, I will try to improve that

I now have a proper setup I think, but rename still didn't work

but clojuredocs now works!

That's awesome :)

rename probably didn't work because of clojure-lsp not finding the correct source-paths

cool :)

maybe we could improve clojure-lsp for nbb projects in the future

yeah, it's a similar problem as babashka I think

exactly

I have no plans for an nbb.edn yet though, perhaps package.json can be considered as a project root as well

maybe, but there is already package.json for npx projects I think

but yeah, we could fallback to nbb maybe

not so important for now, I already showed you one project where I solved it with a deps.edn

actually, there is no rule for package.json ATM

(defn ^:private default-project-specs []
  (->> [{:project-path "project.clj"
         :classpath-cmd ["lein" "classpath"]}
        {:project-path "deps.edn"
         :classpath-cmd ["clojure" "-A:dev:test" "-Spath"]}
        {:project-path "build.boot"
         :classpath-cmd ["boot" "show" "--fake-classpath"]}
        {:project-path "shadow-cljs.edn"
         :classpath-cmd ["npx" "shadow-cljs" "classpath"]}
        {:project-path "bb.edn"
         :classpath-cmd ["bb" "print-deps" "--format" "classpath"]}]
       (map #(update % :classpath-cmd classpath-cmd->windows-safe-classpath-cmd))))

so that maybe could work

it'd be better if there is some way to always know a project is nbb

having a package.json is not entirely true, but sounds like a start

yeah we'll think about it

So I was corrected on Twitter that apparently confused http://cljdoc.org with http://clojuredocs.org, that’s why I initially was amazed in thinking that it would also show docs for other packages, which I guess is not the case then. But that brings me to a question; is it possible to add http://cljdoc.org as well or maybe it’s not a good idea?

Just imagine if you’d also get docs for non-core packages!!!

Though maybe it makes little sense since I think most of it are just reflecting docstrings that we can see anyway. Welp, one can dream!

Yeah, I didn't even know http://cljdoc.org 😅 If they only show docstrings I think this already works ATM with clj-kondo analysis, right?

Oh I knew that site

but yeah, it seems only indexes the docstring which is already available on clojure-lsp. does it allows other things like examples that are not inside the function docstring? I don't think so

It allows regular documentation, but no way to tie any of that to any particular function I think (example: https://cljdoc.org/d/lambdaisland/kaocha/1.0.937/doc/plugin-hooks)

Sorry to spoil the round number, but I just had to go make that 701 🙂

haha thank you!