it's a valid idea, it could be done

but would affect a little performance

clj-kondo already knows if a function is private

it knows when a function is private when it's marked as private

kewl

for other features we would to check the references

we already do that to lens

but we would need to take care with performance

but looks a valid flag/option

Sure. Let me raise it as an issue for consideration on github

yes, please open a feature request with those details 🙂

kk

this would be possible for a clj-kondo analysis perspective

could also make a custom linter from this

yes, that's the idea, is just that custom lint is probably the heavier code of clojure-lsp which checks each var definition and count the references in the project

we need to change it carefully

This okay ?

@U11EL3P9U You could also just write a custom linter for yourself using clj-kondo, while not seeing it in the editor but periodically writing out an HTML report for yourself to view

Vars that are not private but only used in current ns-report.html

Sure, could do, would rather prefer if it was in the editor and done dynamicaly for me as I change the code about and jump from namespace to namespace.

yeah makes sense

they are suppose to be interactive, but it doesn't work for reference lens 😕

explanation:

LSP lens only allows trigger commands when clicking in a code lens, for example a code lens of Run or Debug should trigger a run or debug command for your app

references is something that needs a return, is not a command, so it's tricky, we just show it with a command that doesn't actually exists/works

ah, I see. thank you for the explanation

It could be implemented on lsp-mode/vim etc to support that somehow, but it'd not follow the spec and it'd need to be done on each lsp client

it would be awfully nice if it could open something like lsp-treemacs-call-hierarchy when clicked, for example

IMO this is something that could be improved in LSP spec

yeah, maybe we could hack only lsp-mode to advice that somehow, but it would need custom code just for clojure

perhaps it's better to be patient and wait for the spec to improve

yeah, I probably should save a time to open an issue there 😅

if you figure out how to make it work in lsp-mode, i’ll make it work in coc-nvim

In vscode (JS/TS), clicking a lens shows references. Does that mean vscode doesn't follow the spec? Also, what sort of lsp-mode advice are you thinking @UKFSJSM38?

Probably VSCode is not following/not using LSP for the lens you tested

I know VSCode has its own Js/ts implementation not using lsp

But you can still use LSP with it

But the lens are probably not from lsp

Ah, right. I assumed they are

So, what sort of things make sense to get triggered on Lens click (LSP)? Perhaps we can wrap any of those actions with an advice?

Debug/run lens, like java or Dart have

The typescript lsp and server are tightly bound and have a lot of non standard functionality

Ah 😞 sounds like it'll be a big hack to utilize those for showing call heirarchy/references

The advice is something completely custom done in client, don't know it worth the work

Call hierarchy is already possible with clojure-lsp

Not just via lens click

Technically because of how the message protocol works, clojure-lsp could do the same but then we'd have to implement that behavior in each client

I mean, with lens click as @U0178V2SLAY said

Yea, nvm. Actually I don't know why I'm invested in this 😛 I rarely use my mouse

I think custom methods are good for features specific for each lang/server like clojure which has a custom one to "resolve a macro as..." Which automatically change your clj-kondo config

https://clojure-lsp.github.io/clojure-lsp/capabilities/#custom-methods

Agreed. A non-standard feature I do want to get into clojure-lsp at some point is “import X from namespace Y” in the completion menu, but I need to do more research on how tsserver does it first to get an understanding of what that entails

clojure-lsp does that already, to some extent as far as I know

oh? when typing an unknown var, the completion will say “import X from namespace Y” and then if you highlight it and press “enter” (or whatever), it completes the symbol while also adding it to the namespace declaration?

Weird, just tried it. Doesn't work anymore. I remember (once or twice in the past): • Typing some-func • Executing code actions • Selecting: import some-func from some-ns @UKFSJSM38 Was this supported at one point?

oh, as a code action i think that works

just not as a combined part of completion

Right, yea. I sometimes use emacs for TS/JS and the completion is via code action. In vscode it's part of completion, yea

The code action works, and we have support for add when completed as well, not sure if there is a bug

Oh really? I can’t get the “add when completed” to work

Maybe I'm doing it wrong

we used to have that, let me check if it's working

yep, working

it works when completing an alias

Hmm, I expect go-loop to be suggested here (from core.async)

there are rules to require, for both completion or code action, clojure-lsp will be able to require a ns if: • it's a known common alias, like string , io , set async etc • the alias was already required before in a ns of the project, otherwise there is no way for clojure-lsp know.

your case is not an alias, is a refer, we could improve clojure-lsp to understand some common refers like go-loop , actually, it already knows deftest testing is

Does kondo know about every public var in all classpath namespaces? Does clsp?

yes

we just need to be careful with what we add to completions without anything typed yet, because clojure-lsp already return 800+ items, if we'd add all public vars of all classpath that would probably blow up

Oh wow, interesting. Guess I don’t know how the completion works. I thought it was as you typed, not before

Ah right

the completion can be triggered at any time, with something typed or even with nothing typed yet

FYI: I added clojure.async.core common macro/functions to suggested require code actions: https://github.com/clojure-lsp/clojure-lsp/commit/934e41cf7373d12d4fa8bf073cdcb78c44a33a55