Fork me on GitHub
#cljdoc
<
2021-08-06
>
martinklepsch08:08:03

There’s no whitelisting or anything different in prod. If you see it locally it may happen in prod. :face_with_rolling_eyes:

seancorfield17:08:46

Does cljdoc already use clj-http? It drags in a lot of dependencies. We switched over to http-kit's client at work (because the async stuff is more convenient to use, as well as it having no dependencies).

seancorfield18:08:20

(! 941)-> clojure -Stree -Sdeps '{:deps {clj-http/clj-http {:mvn/version "RELEASE"}}}'
org.clojure/clojure 1.10.3
  . org.clojure/spec.alpha 0.2.194
  . org.clojure/core.specs.alpha 0.2.56
clj-http/clj-http 3.12.3
  . org.apache.httpcomponents/httpcore 4.4.14
  . org.apache.httpcomponents/httpclient 4.5.13
    X org.apache.httpcomponents/httpcore 4.4.13 :older-version
    . commons-logging/commons-logging 1.2
    X commons-codec/commons-codec 1.11 :older-version
  . org.apache.httpcomponents/httpclient-cache 4.5.13
    . org.apache.httpcomponents/httpclient 4.5.13
    . commons-logging/commons-logging 1.2
  . org.apache.httpcomponents/httpasyncclient 4.1.4
    X org.apache.httpcomponents/httpcore 4.4.10 :older-version
    . org.apache.httpcomponents/httpcore-nio 4.4.10
      X org.apache.httpcomponents/httpcore 4.4.10 :older-version
    X org.apache.httpcomponents/httpclient 4.5.6 :older-version
    . commons-logging/commons-logging 1.2
  . org.apache.httpcomponents/httpmime 4.5.13
    . org.apache.httpcomponents/httpclient 4.5.13
  . commons-codec/commons-codec 1.15
  . commons-io/commons-io 2.8.0
  . slingshot/slingshot 0.12.2
  . potemkin/potemkin 0.4.5
    . clj-tuple/clj-tuple 0.2.2
    . riddley/riddley 0.1.12

seancorfield18:08:01

(I guess "a lot" is subjective 🙂 )

Joshua Suskalo18:08:10

wait clj-http uses slingshot?

Joshua Suskalo18:08:37

Interesting. I've been meaning to take a peek at its implementation for a bit. This reminded me.

lread18:08:55

cljdoc is not shy about bringing in external deps simple_smile

lread18:08:35

Ha! Yeah, I see your point.

lread18:08:44

Cljdoc is maintained sporadically by many different devs. If there is a well tested, much trusted thing out there then I tend to bring it in even it is smallish. Just to avoid cljdoc dev team having to maintain it. But pros and cons to everything, right?

lread18:08:42

Yeah. And there is no one “right” answer.

lread18:08:05

Ah… yes (after googling!) “In matters of taste, there can be no disputes” Worthy of a T-Shirt.

3
lread18:08:45

Dignum a T-Shirt?

lread18:08:07

Ha! Perfect.