Fork me on GitHub
#introduce-yourself
<
2023-05-25
>
Jack Gee10:05:45

Hi guys, I'm Jack from the UK. My background is in python for data analytics, engineering and science but I really enjoy tinkering with Clojure. I would consider myself a Clojure beginner after playing around with it a bit around 6months ago and getting back into it again now! Looking for all the tips and tricks, so sure I'll be visiting here a bit. Also, feel free to check out a webscraper I put together on github! Would love some feedback 🙂 https://github.com/jackottogee/webscraper Look forward to talking to you all! clojure

2
👋 12
4
Martin Půda11:05:23

Some feedback: • you don't have to repeat :require, use just one (https://github.com/bbatsov/clojure-style-guide#sort-requirements-and-imports) • strange indentation (for example in make-url - function body belongs right under the argument vector, but you have there some additional space) (https://github.com/bbatsov/clojure-style-guide#optional-new-line-after-fn-name) • in data->singular, you could use -> to avoid nesting and destructuring instead of let • you could rewrite is-value? with and:

(defn is-value?
  "Returns true when :value starts with a digit in maps `m` from [[map-rows]]."
  [{:keys [value]}]
  (and (string? value)
       (Character/isDigit ^char (first value))))

❤️ 2
seancorfield15:05:33

@U0596F9G4DT check out the (quiet) #C064BA6G2 and (casual) #CBJ5CGE0G channels.

❤️ 2