Fork me on GitHub
#lsp
<
2023-05-25
>
lassemaatta05:05:45

I noticed recently that I no longer see the the startup progress status in emacs modeline. Any idea what might cause this? (EDIT: most likely a pebkac issue)

lassemaatta05:05:09

my global-mode-string contains (among other things)

(t
  (:eval
   (-keep #'lsp--workspace-status-string
          (lsp-workspaces))))
and my mode-line-format includes mode-line-misc-info which, if I understand this correctly, should be enough to show the progress in the modeline

lassemaatta05:05:15

I guess I'm building my mode line incorrectly, as evaling (-keep #'lsp--workspace-status-string (lsp-workspaces)) while the workspace is restarting shows that the status is received and looks ok :man-shrugging:

lassemaatta05:05:27

hmm.. the problem persists even if I remove my mode line config and even run with lsp-start-plain :thinking_face:

ericdallo11:05:59

There were no changes in lsp-mode and clojure-lsp regarding that AFAIK. So you are saying the problem happens even with lsp-start-plain not using any of your config?

ericdallo11:05:20

Hum, I'll double check if anything changed on lsp-mode

lassemaatta11:05:56

thanks, but don't spend too much time on this; I think this is a rather minor issue after all

lassemaatta11:05:50

if I had to guess I'd say its been several weeks at least when I've last seen the progress bar working

lassemaatta11:05:40

if this even is a lsp-mode issue (I don't know how reliably lsp-start-plain excludes my local settings/packages)

ericdallo12:05:49

Yeah that may be related, @U043RSZ25HQ may know more about it easily

Ellis12:05:25

I'll have a look later :)

lassemaatta12:05:55

thanks to both of you 👍

ericdallo13:05:33

I was using an outdated lsp-mode, after updating, I can confirm there's no progress on the modeline anymore, probably related to that commit

ericdallo13:05:57

it's funny no one complained about that until now, that reinforces that clojure-lsp is one of the few LSPs that show progress during initialization 🙂

Ellis13:05:53

I think it is, im at the juxt event atm but I'll fix it when I can :)

👍 2
lassemaatta13:05:32

And most people don’t work with projects that take several minutes to load harold

😅 2
ericdallo13:05:46

that progress bar is one of the coolest features of clojure-lsp IMO 😛

lassemaatta13:05:49

I've spent so much time with it that not seeing the progress bar is like losing a dear friend

😂 2
Ellis08:05:52

I haven't forgotten about this, recently had to reinstall my laptop & just got back from juxt event so busy busy. When I committed it, it was definitely working but in the meantime it can be reverted until I get a fix I can verify more 🙂

👍 2
lassemaatta08:05:42

Sure, no problem. Feel free to ping me later if you want me to verify if its fixed or not.

ericdallo01:06:53

Reverts the PR meanwhile, could you approve it please @U043RSZ25HQ? reviewplease https://github.com/emacs-lsp/lsp-mode/pull/4067

lassemaatta13:06:10

wohoo, it works again 👍

🎉 1
ericdallo13:06:56

I started to feel the same after I updated lsp-mode 😂

Ellis19:06:53

Sorry I've been away for a few days, glad this has been reverted in any case

👍 2