Fork me on GitHub
Slack Archive

This page is not created by, affiliated with, or supported by Slack Technologies, Inc.

2022-10-05

Channels

#fulcro
<
2022-10-05
>
JAtkins13:10:27

Morning! @tony.kay I've just raised a PR against fulcro, but it seems that the develop branch is missing at the moment. It's currently listed as a diff against master. https://github.com/fulcrologic/fulcro/pull/521

👍 1
tony.kay14:10:08

I dropped develop

JAtkins15:10:14

ok, so it should be against master now?

tony.kay15:10:35

correct. Library changing slowly enough at this point that git flow just doesn’t make sense…just adds extra steps with no benefit

👍 2
tony.kay17:10:59

Hey @U5P29DSUS could you tweak that one spot in your PR I commented on?

tony.kay17:10:14

once that’s done I’ll cut a release

tony.kay17:10:27

pls squash as well 🙂

tony.kay17:10:35

or I will on merge…either way

JAtkins17:10:30

Sure, I've squashed for now. I'll ping ya when my test suite has run just to make 100% sure I didn't bork something by swapping to conj/`pop`

JAtkins17:10:43

yep all good

tony.kay17:10:36

I’ll take it out for next release

metal 1
zhuxun216:10:39

Looks like it should perhaps be :debug?

Joe R. Smith23:10:00

Using Fulcro RAD 1.3.1 with Fulcro 3.5.6 emits this build error: 

[:main] Build failure:
------ ERROR -------------------------------------------------------------------
 File: jar:file:/Users/solussd/.m2/repository/com/fulcrologic/fulcro-rad/1.3.1/fulcro-rad-1.3.1.jar!/com/fulcrologic/rad/form.cljc
failed to require macro-ns "com.fulcrologic.rad.form", it was required by "com.fulcrologic.rad.form"

tony.kay03:10:06

Which compiler are you using? What version? The require it is complaining about is how you get auto-requires of macros in cljs, and it has been working since the very f irst release. I suspect something is wrong in your build, or caches.

✅ 1
Joe R. Smith04:10:18

thheller/shadow-cljs                {:mvn/version "2.15.12"}
org.clojure/clojurescript              {:mvn/version "1.10.866"}
I nuked the caches for shadow-cljs and the artifacts in public/js

Joe R. Smith04:10:56

all else the same but 

com.fulcrologic/fulcro-rad             {:mvn/version "1.1.0-RC8-SNAPSHOT"}
works

tony.kay04:10:28

I'm using the latest everything in a250kloc project. Not sure which version of shadow

✅ 1
thheller06:10:15

you can check what failed with more detail by running npx shadow-cljs clj-repl and (require 'com.fulcrologic.rad.form :reload)

thheller06:10:40

you should get a full error report/stacktrace for why the clj namespace failed to load

👍 1
thheller06:10:17

didn't look at the code but maybe it used clojure 1.11 functions when running clojure 1.10?