Fork me on GitHub
#lsp
<
2022-10-05
>
robert-stuttaford07:10:29

would it be possible to support go-to-definition from *cider-result* / *cider-repl ...* ? when i try: lsp--path-to-uri-1: Wrong type argument: stringp, nil

šŸ™ 1
ericdallo11:10:22

Hum, would be interesting to support that, the main issue is that lsp-mode doesn't recognize cider buffer as a clojure one, but I think it's possible to change that via some setting

ericdallo11:10:35

then we would need to "understand" a repl buffer code on clojure-lsp side, so not sure if that would work that great, but worth the try. IIRC, Calva does set the repl buffer as a clojure one since we had issues in the past where we are linting a long repl buffer affecting performance

robert-stuttaford12:10:22

honestly not all that fussed about repl, but the result buffer would be a big win

ericdallo12:10:26

yeah, I can see how convenient, I think the main issue would be parse the result and understand what is a var or not, clj-kondo doesn't support that ATM and not sure if @U04V15CAJ would be interested on that

snoe21:10:15

it's an interesting thought experiment, it becomes quite difficult without knowing which namespace the results were interpreted in. maybe along with the file-type being set, you could make emacs/cider add a (list* 'ns *ns*) evaluation to results when you change ns.

ericdallo18:10:59

clojure-lsp Released https://clojure-lsp.io/ https://github.com/clojure-lsp/clojure-lsp/releases/tag/2022.10.05-16.39.51 with lots of improvements and fixes šŸŽ‰ ā€¢ General ā—¦ Improve clj-depend merge config to overwrite source-paths only if it is nil or empty. https://github.com/clojure-lsp/clojure-lsp/issues/1264 ā—¦ Fix stubs generation issue on MS-Windows, coming out of enabling all integrations tests on windows. https://github.com/clojure-lsp/clojure-lsp/issues/1211 ā—¦ Improve MS-Windows support by fixing various path, URI and line ending issues coming out of repairing the unit tests suite on windows. https://github.com/clojure-lsp/clojure-lsp/issues/1211 ā—¦ End dep-graph-queries experiment; clojure-lsp now uses the dep-graph to optimize queries whenever possible ā—¦ Bump clj-kondo to 2022.10.05. https://github.com/clojure-lsp/clojure-lsp/issues/1226 ā—¦ Fix issue with changes being reporting with spurious and incorrect line endings on MS-Windows text files. https://github.com/clojure-lsp/clojure-lsp/issues/1211 ā—¦ Index internal data by URI instead of filename, to minimize conversion between these formats when running queries. https://github.com/clojure-lsp/clojure-lsp/issues/1207 ā—¦ Add support to enable trace logs on server via --trace flag. (For latest Emacs's lsp-mode this can be enabled easyly via lsp-clojure-trace-enable variable) ā—¦ Bump graalvm version for MS-Windows to 22.2.0, in sync with the other archs. https://github.com/clojure-lsp/clojure-lsp/issues/1211 ā€¢ Editor ā—¦ Fix to avoid error when checking code actions from an #_x uneval node. https://github.com/clojure-lsp/clojure-lsp/issues/1227 ā—¦ Add support to decompile jar as a java project when finding the definition of a java class, allowing to have LSP features on that java project. https://github.com/clojure-lsp/clojure-lsp/issues/1187 ā—¦ Add refactorings similar to Sort map: Sort vector, Sort list, Sort set, and Sort clauses for functions like assoc. https://github.com/clojure-lsp/clojure-lsp/issues/1155 ā—¦ Support java class decompilation for zipfile scheme (vim users). ā—¦ Avoid keeping diagnostics of external closed files for Calva. https://github.com/BetterThanTomorrow/calva/issues/1864 ā—¦ Lint opened files after a clojure-lsp or clj-kondo config file is saved on disk, avoiding users to re-edit files. https://github.com/clojure-lsp/clojure-lsp/issues/1247 ā—¦ Allow find definition of java class usages where definition comes from clojure, like defrecords. ā—¦ Fix: wait for rename to apply before allowing another rename, to ensure suggested name is correct. https://github.com/clojure-lsp/clojure-lsp/issues/1270 ā—¦ Process requests in parallel, to prevent typing lag and other performance problems introduced during migration away from lsp4j. https://github.com/clojure-lsp/clojure-lsp/issues/1240 ā—¦ Fix: Avoid wrong ns require after Create ns and require code-action/command. ā—¦ Fix: Avoid errors when a file starts with a comment. https://github.com/clojure-lsp/clojure-lsp/issues/1252 ā—¦ Bump promesa to 9.0.462 and use it for parallel request processing. ā€¢ API/CLI ā—¦ Fix missing diagnostics when --project-root is different than current directory. https://github.com/clojure-lsp/clojure-lsp/issues/1245 ā—¦ Add new dump feature, returning analysis, project information, dependency-graph and others. Check clojure-lsp.api/dump for more information. https://github.com/clojure-lsp/clojure-lsp/issues/744 ā—¦ Improve CLI output avoiding logs from clj-kondo which are already available via verbose log. Main highlights: ā€¢ Critical performance fix introduced on previous release, please try this release if having any performance issues. Kudos to @jacob.maine ā€¢ We now have a new CLI/API command: clojure-lsp dump -- This should build and return lots of information about your project like clj-kondo normalized analysis, project information, dependency-graph and others, if you want do some kind of data analysis in your project/s, consider giving it a try. ā€¢ Lots of critical fixes for Windows -- Thanks to the huge help of @chaos (@ikappaki) ā€¢ We now decompile the whole jar if it's a java project, offering whole lsp-java features šŸš€ Thank you for all supporters and help during this release! gratitude

clojure-lsp 7
clojure-spin 3
gratitude 3
calva 2
šŸ™ 3
šŸŽ‰ 5