This page is not created by, affiliated with, or supported by Slack Technologies, Inc.
2022-09-15
Channels
- # ai (35)
- # announcements (3)
- # babashka (16)
- # babashka-sci-dev (2)
- # beginners (37)
- # biff (16)
- # calva (5)
- # cider (2)
- # clj-commons (81)
- # clj-kondo (29)
- # cljfx (2)
- # cljs-dev (4)
- # clojars (4)
- # clojure (92)
- # clojure-europe (72)
- # clojure-losangeles (8)
- # clojure-nl (1)
- # clojure-norway (10)
- # clojure-uk (1)
- # clojurescript (20)
- # clojutre (2)
- # conjure (2)
- # data-science (18)
- # datomic (1)
- # emacs (10)
- # fulcro (49)
- # joyride (1)
- # kaocha (23)
- # leiningen (8)
- # lsp (14)
- # meander (5)
- # off-topic (93)
- # polylith (4)
- # re-frame (20)
- # reagent (9)
- # reitit (2)
- # remote-jobs (8)
- # sci (1)
- # shadow-cljs (21)
- # testing (3)
- # vim (27)
- # xtdb (35)
I noticed that reset!
is defined on line 4521 of cljs/core.cljs and then it is later declared on line 7272. This https://github.com/cursive-ide/cursive/issues/2730 to not show the docstring for reset!, presumably because the declare
is overriding the reset!
.
Looking back at Git history, it seems like the declare
used to be https://github.com/clojure/clojurescript/blob/ef0d52541b02bcf767f2f54f497c8808c6afa91d/src/cljs/cljs/core.cljs#L2721, and then the defn reset!
https://github.com/clojure/clojurescript/blob/ef0d52541b02bcf767f2f54f497c8808c6afa91d/src/cljs/cljs/core.cljs#L3853.
I think that now some of those declared vars could be removed because they are already defined at the point of declaration?
I took a quick scan and it seems like this:
(declare create-inode-seq create-array-node-seq reset! create-node atom deref)
could be safely rewritten to
(declare create-inode-seq create-array-node-seq create-node)