Fork me on GitHub
#cljs-dev
<
2020-04-01
>
Filipe Silva09:04:58

I'm not sure who I should ping about the closurescript site, but the interop patch also included docs

Filipe Silva09:04:45

@dnolen @alexmiller could this be merged as well?

thheller10:04:22

ehm that cljs.core.async.interop CLJS ns is missing the :require-macros for itself. makes it kinda annoying to use. https://github.com/clojure/core.async/commit/4b71889e1ba2c909ff30e75af37f7c41e0b75fc7

👍 4
dnolen10:04:54

@thheller hrm weird that it seems the tests passed w/o that, thanks adding now

👍 8
Filipe Silva13:04:44

must have been because the tests used :refer-macros

Filipe Silva13:04:45

(ns cljs.core.async.interop-tests
  (:require-macros [cljs.core.async.macros :refer [go]])
  (:require [cljs.core.async :refer [<!]]
            [cljs.core.async.interop :refer [p->c] :refer-macros [<p!]]
            [cljs.test :refer-macros [deftest is async]]))

Filipe Silva13:04:49

sorry about that 😐

dnolen13:04:04

@alexmiller would need another bump w/ the change I just pushed

Alex Miller (Clojure team)13:04:05

core.async 1.1.587 is working its way through maven

Alex Miller (Clojure team)13:04:50

also, I applied a pre block scroll css fix that we added recently on the clojure site so some of that stuff looks better

❤️ 4
Filipe Silva13:04:51

very excited to see my contribution there 😄 (even though it was mostly copy paste of David's code)

metal 8
dnolen13:04:18

this is great! Thanks all!

⛄ 4
Alex Miller (Clojure team)13:04:28

still waiting on maven - at the end of the month they have some big batch stats job that always slows things down for a few days

mfikes16:04:37

With ClojureScript master and a downstream re-natal-based project I get "Cannot use default debug loader outside of HTML documents." I'm going on the assumption that this is not a ClojureScript problem but instead re-natal (or Figwheel) would need to be updated for the latest Closure stuff. (Planning on logging a downstream ticket if I can get a clean repro there.)

dnolen16:04:20

@kommen hey I've added :target-fn to master to allow custom bootstrapping code for :none mode

dnolen16:04:59

@mfikes re: re-natal that might be easy to fix, the issue is that re-natal doesn't define CLOSURE_IMPORT_SCRIPT

dnolen16:04:32

rather it uses FIGWHEEL_IMPORT_SCRIPT which seems dubious, but maybe necessary for Figwheel to handle it's hot-reloading?

kommen19:04:21

@dnolen ok, thanks. I’ll use that for graaljs