Fork me on GitHub
#cljdoc
<
2019-10-29
>
martinklepsch09:10:43

@holyjak just taking a final look at the /versions PR — this isn’t needed anymore is it? https://github.com/cljdoc/cljdoc/pull/357/files#diff-7ac04933e500c3f3e36d5bba2a7932faR78

martinklepsch09:10:40

@holyjak I’m thinking maybe we just drop that body interceptor and instead of putting stuff into the ::releases key we just put it into :response {:body releases :status 200}

martinklepsch09:10:23

in the ::releases-loader that is

martinklepsch09:10:42

I’m happy to make that change but wanted to check how you feel about it

👀 4
Jakub Holý10:10:08

You mean essentially mergin what body + body-fn do directly into ::releases-loader interceptor? Why not. Please do it!

martinklepsch11:10:49

yeah pretty much

martinklepsch11:10:08

since it’s only used once it feels like maybe not worth committing to the helper yet

Jakub Holý11:10:05

Ok. Please change it as you see fit and merge. Thank you!

👍 4