Fork me on GitHub
#cljs-dev
<
2019-10-29
>
dnolen00:10:58

@filipematossilva thanks! did you already submit a CA?

Filipe Silva12:10:15

I submitted one about 6 months ago, is that still in effect?

Filipe Silva12:10:48

Yes, I can confirm I have email confirmation saying "Clojure CA between Rich Hickey and Filipe Silva is Signed and Filed!" from June 3

dnolen17:10:09

k great, thanks

Filipe Silva20:10:30

Now I that it's live I see I broke the anchor format (it can't have spaces). I'm sorry for that. https://github.com/clojure/clojurescript-site/pull/329 shows the problem and fixes it.

mkvlr08:10:45

we’re seeing js file with syntax errors generated recently, without having changed the clojurescript version. We’re doing more js interop e.g. via set!. An example of an error would be a missing namespace, e.g. .autocompleter_choice = (function …) where com.nextjournal.editor.article.gutter_actions.autocompleter_choice = (function …) would be correct. Anybody else notice something like this?

mkvlr08:10:40

we do have :parallel-build true set

thheller08:10:08

@mkvlr this is likely related to on inference bug that was fixed in master. can't quite remember the details but it was causing incorrect code like that

mkvlr08:10:51

@thheller ok, we’ll try updating to latest master and see if that helps, thanks!

mkvlr08:10:41

and it could still be non-deterministic in that case?

mkvlr08:10:38

ah, and we’re using a version with that patch included

thheller08:10:13

hmm thats the only recent code gen bug I can remember

mkvlr08:10:25

we’ll try an update anyway

dpsutton12:10:07

@mkvlr do you use a top level letfn form by any chance? This can produce functions without namespaces

mkvlr12:10:52

@dpsutton no, at least not in our code directly

kommen14:10:57

to clarify: the invalid js files produced as @mkvlr described are not deterministic, so when just changing whitespace in the cljs file and recompiling, the js file is ok again. we do use figwheel-main with live code reload, not sure if this can be a factor here

thheller14:10:20

how does the actual .js file look? I had some very weird output when 2 separate threads/processes were writing the same file at rougly the same time

thheller14:10:15

dunno about figwheel through