Fork me on GitHub
Jeff Evans15:09:51

Hi, all. I wanted to report what appears to be a typo, primarily to help cement my own understanding. Tried reaching out to Daniel in a couple different ways with no response. In this chapter: Specifically, the last `defmacro code-critic` has its arguments as `[{:keys [good bad]}]`, but I believe it should just be a plain vector: `[good bad]`


I would agree, based on the example. It’s a 2-arg macro, not a macro that takes a map and destructures it.


It also looks like the bad and good arguments are swapped, relative to the example he gives and the output he shows.


Or wait, in map destructuring, the order is undefined. But anyway for the given example to produce the given output, the arguments would have to be [bad good]

Jeff Evans15:09:48

Thanks for the second set of eyes, @manutter51! Appreciate it

👍 3