Clojurians Log v2

In Python you need to use the lower level zipfile module and recurse down the dir structure and manually supply the filename in the write method: https://docs.python.org/3.10/library/zipfile.html#zipfile.ZipFile.write The dir walk is bit eased with Pathlib:

from pathlib import Path 

def zipdir(parent_dir : str , ziph : ZipFile) -> None:
    
    for file in Path(parent_dir).rglob('*'): # gets all child items
        ziph.write(file, file.name) 

yeah, this is too hard in Python if you ask me :)

We could just provide a function to do the renaming

theres no abstracted way to do this in py afaik

maybe an option like {:flatten true} or {:preserve-heirarchy true}

flatten true would not cover the use case of adding foo/bar/baz and then have bar/baz in the zip

so its more of a selective filter?

hierarchal filter of sorts?

you don't know this use case? you have a directory src/foo/bar.clj but you would like to have foo/bar.clj in the zip

yeah i get around it with zipping src/* and others manually, havent had a need to just stripping one level yet

how do you "zip manually"

manually as in add all the needed parts step by step, not specifying what i need in a full dir

(zip archive "src/foo/*") (zip archive "src/bar/*") and more such calls

this is not using fs/zip which is what the issue is about :)

yep got it, just never thought of a need for this 😛

Ruby has a python like api too, seeing these two i think a :rename-fn would be the most similar

yeah, seems good to me