lsp can do that

I'm not sure exactly how to test that from the CLI, but when I try using the rename functionality in my Neovim I get inconsistent results: For example:

(let [{:foo/keys [bar]} {:fo|o/bar 1}]
  bar)

(let [{:foo/keys [baz]} {:foo/baz 1}]
  bar)

the plus side is that I also use neovim

but does not really understand what you would like to change

if you want change :foo/bar and want to change`[bar]` also, it will not work 😞

https://github.com/clojure-lsp/clojure-lsp/blob/ebfe4d30ba435591edeec128732f6ab36c7b19fa/lib/src/clojure_lsp/feature/rename.clj#L18

although in theory such a function is supported

The bindings in the let form are updated, but the change introduces an undefined var in the let body this way. The end result is broken code. If it produces changes like this I think it's safer to go through and make the substitutions manually.

I think I've seen cases where it doesn't keep the right indentation as well. Maybe it's conflicting with my rust-parinfer or something? I wonder if this is one of those operations for which it's better to disable parinfer.

I don't know if this is not a regression, it seems to me that it used to work

@UPWHQK562 https://github.com/clojure-lsp/clojure-lsp/issues/978

at least it looks like there is a willingness to handle it

properly

Hmm, I think I'm on latest. I'll double check when I get back to my machine. Thanks for taking a look @U0BBFDED7.

no problem

you can always ask eric on slack, he is always happy to help