saw that, ty

will add lein instructions to the readme. hope to publish a new build soon as well, master is stable

looking forward to it

it's correct, maybe someone can contribute a kondo rule

you can also use def or *1

thanks, I have not reached the level of kondo rules... yet

I could use those but for a noob that seems a bit like magic

it also takes the code locality away a bit

if it's not too much to ask, I think that the above (multiple tests on a value) can also make it to the docs.

or I can try to add it ?!

you can send a PR that adds an example to the readme if you want

https://github.com/hyperfiddle/rcf/pull/57

I have added a PR to remove the warning around := here: https://github.com/hyperfiddle/rcf/pull/77

thank you!

@U051S5XR3 can you post here a concrete example you are using to test?

I.e. this seems a bit nuanced, in (tests (def a 1) a := 1) is 1 also considered unused by kondo? is a?

a is considered unused here

I have to go AFK at the moment, but I will test this against a repl and update here later in the night. Yea, this PR removes the warnings for all unused values, but I thought it was a decent compromise. Linting it using other means seems much more complicated.

I'll ping borkdude to validate but i want to make sure I understand the exact pain point you're solving first

so it is not just := but also a

Okay, so I looked into it some more today

The definition of :unused-value in the documentation is: _Description:_ warn on unused value: constants, unrealized lazy values, pure functions and transient ops (assoc!, conj! etc).

without any clj-kondo config, if I have the following code:

(rcf/tests
 "Ensure connection"
 (start-pool! *test-data-source*) := nil
 *test-data-source* := nil
 (start-pool! *test-data-source*) *test-data-source* := nil

 "Drop existing test table, if any"
 (-> *test-data-source*
     (jdbc/execute-one! ["drop table if exists invoice"])
     keys)
 := '(:next.jdbc/update-count))

but if I put this in a let binding:

(ns temp
  (:require
   [hyperfiddle.rcf :as rcf]
   [next.jdbc :as jdbc]))

(defn start-pool!
  [data-source]
  (with-open [conn (jdbc/get-connection data-source)]
    (.close conn)))

(rcf/tests
 (let [*test-data-source* {:dbtype "sqlite"
                           :dbname "development/db/testing.sqlite"
                           :dataSourceProperties {:socketTimeout 30}}]
   "Ensure connection"
   (start-pool! *test-data-source*) := nil
   *test-data-source* := nil
   (start-pool! *test-data-source*) *test-data-source* := nil

   "Drop existing test table, if any"
   (-> *test-data-source*
       (jdbc/execute-one! ["drop table if exists invoice"])
       keys)
   := '(:next.jdbc/update-count)))

15   4 warning         Unused value: "Ensure connection" (clj-kondo-clj)
           16  37 warning         Unused value: := (clj-kondo-clj)
           16  40 warning         Unused value: nil (clj-kondo-clj)
           17   4 warning         Unused value: *test-data-source* (clj-kondo-clj)
           17  23 warning         Unused value: := (clj-kondo-clj)
           17  26 warning         Unused value: nil (clj-kondo-clj)
           18  37 warning         Unused value: *test-data-source* (clj-kondo-clj)
           18  56 warning         Unused value: := (clj-kondo-clj)
           18  59 warning         Unused value: nil (clj-kondo-clj)
           20   4 warning         Unused value: "Drop existing test table, if any" (clj-kondo-clj)
           24   4 warning         Unused value: := (clj-kondo-clj)

With the clj-kondo config I have proposed all these warnings are removed. Even if it’s excessive, I think it is an acceptable linting configuration, since rcf/tests forms are only meant to work during development. Let me know what you think.

The pain point is that these warnings mix up with other warnings and leads to everyone ignoring warnings altogether, which is not nice. It should be possible to write tests nested in a let or when or other Clojure forms without clj-kondo blowing up