Fork me on GitHub
#tools-deps
<
2019-12-06
>
dominicm20:12:08

I just responded to this pack issue which I think is a tdeps bug, but I don't know much about maven/pom.xml, so it might be helpful to @drewverlee if someone who was more familiar took a look: https://github.com/juxt/pack.alpha/issues/68#issuecomment-562717952 Essentially it doesn't seem like the sourceDirectories in pom.xml are being read.

drewverlee20:12:27

On my phone atm, I'll be back home on Sunday and I'll look into this.

drewverlee20:12:36

Thanks for looking into the issue.

dominicm20:12:58

Looks like I'm wrong, I'll take another look in a minute :)

alexmiller20:12:06

I don't understand what the expected and actual behavior is?

alexmiller20:12:30

I tried

clj -Spath -Sdeps '{:deps {integrant {:git/url "" :sha "c673b85130e553feec6d4c5d2d1ec773a49c929c"}}}'

alexmiller20:12:41

and got

src:/Users/alex/.m2/repository/org/clojure/clojure/1.10.1/clojure-1.10.1.jar:/Users/alex/.gitlibs/libs/integrant/integrant/c673b85130e553feec6d4c5d2d1ec773a49c929c/src:/Users/alex/.gitlibs/libs/integrant/integrant/c673b85130e553feec6d4c5d2d1ec773a49c929c/src/main/clojure:/Users/alex/.gitlibs/libs/integrant/integrant/c673b85130e553feec6d4c5d2d1ec773a49c929c/resources:/Users/alex/.m2/repository/org/clojure/spec.alpha/0.2.176/spec.alpha-0.2.176.jar:/Users/alex/.m2/repository/org/clojure/core.specs.alpha/0.2.44/core.specs.alpha-0.2.44.jar:/Users/alex/.m2/repository/weavejester/dependency/0.2.1/dependency-0.2.1.jar

alexmiller20:12:14

what is expected that's different?

alexmiller20:12:12

that includes the srcDirectory (src)

dominicm20:12:05

Oh. So it does. My mistake. Reading long strings is hard. I missed that.

sogaiu20:12:31

(side note) ^ been feeding classpaths to sed to separate them darn things 🙂 also was tipped off to using grep's color option to pick out specific things: https://github.com/jpmonettas/clograms/issues/3#issuecomment-560017206

ghadi20:12:00

I feed them to clj -Spath | tr ':' '\n'

dominicm20:12:20

Ah, the user is using a version of pack running an older tdeps which predates this jira: https://clojure.atlassian.net/projects/TDEPS/issues/TDEPS-96

dominicm20:12:23

I need to upgrade to the 0.8.x series really, I'm just not keeping on top of this stuff very well at the moment. Life is busy.

alexmiller20:12:25

well, should be no breaking changes :)

seancorfield22:12:20

@alexmiller I noticed that recent versions of clojure/t.d.a. actually strip existing newlines from POM files -- was that intentional when you fixed TDEPS-29?

seancorfield22:12:13

In my pom.xml files, I tend to have blank lines separating sections at the top-level. clojure -Spom now removes those blank lines. Which is really annoying -- it should not mess with the existing layout.

alexmiller22:12:49

It was not intentional but makes sense why that would be

alexmiller22:12:34

As you know, parsing, modifying, then emitting xml is tough to do w/o something like this happening

alexmiller22:12:16

(Really, xslt is a better tool for this job but I didn’t have much luck going down that route)

alexmiller22:12:48

Patches welcome :)

dominicm23:12:46

Is xslt whitespace preserving?

seancorfield23:12:45

I don't consider it quite annoying enough to create a JIRA issue so I'll just learn to live with it 🙂

alexmiller23:12:41

xslt has a lot of options, not sure. I did look seriously at it back when I wrote the pom sync, but that was a couple yrs ago, don't remember the tradeoffs now.