Another use-case for https://clojure.atlassian.net/browse/TDEPS-116 — I want to create a library that has different code for different jdk versions. I do it using 2 aliases:

{:jdk8 {:extra-paths ["src/jdk8"]}
 :jdk11 {:extra-paths ["src/jdk11"]}}

I think I found a bug: :paths in aliases are not picked up when there are also :deps present. Repro: deps.edn:

{:paths ["src" "jdk11"]
 :aliases {:jdk8 {:paths ["src" "jdk8"]
                  :deps {org.clojure/clojure {:mvn/version "1.10.1"}}}}}

src:jdk11:/home/vlaaad/.m2/repository/org/clojure/clojure/1.10.1/clojure-1.10.1.jar:/home/vlaaad/.m2/repository/org/clojure/spec.alpha/0.2.176/spec.alpha-0.2.176.jar:/home/vlaaad/.m2/repository/org/clojure/core.specs.alpha/0.2.44/core.specs.alpha-0.2.44.jar

src:/home/vlaaad/.m2/repository/org/clojure/clojure/1.10.1/clojure-1.10.1.jar:/home/vlaaad/.m2/repository/org/clojure/spec.alpha/0.2.176/spec.alpha-0.2.176.jar:/home/vlaaad/.m2/repository/org/clojure/core.specs.alpha/0.2.44/core.specs.alpha-0.2.44.jar

and sometimes :deps are not picked up? Given this deps.edn:

{:paths ["src" "jdk11"]
 :aliases {:jdk8 {:paths ["src" "jdk8"]}
           :deps {cljfx {:mvn/version "1.5.1"}}}}

src:jdk8:/home/vlaaad/.m2/repository/org/clojure/clojure/1.10.1/clojure-1.10.1.jar:/home/vlaaad/.m2/repository/org/clojure/spec.alpha/0.2.176/spec.alpha-0.2.176.jar:/home/vlaaad/.m2/repository/org/clojure/core.specs.alpha/0.2.44/core.specs.alpha-0.2.44.jar

In maven that's a classifier I think. Although jdk11 had a system for having jdk-specific files added.

@vlaaad jep238: multi release jars

It would be cool if deps.edn supported MRJAR for fetching dependencies.

I don’t think mrjars have any effect on deps? That’s really a JVM thing?

On the problem above, what version of clj are you on?

latest, 1.10.1.148

@dominicm will jep 238 work with clj files as well? is it okay to make library muti-release?..

I was thinking of fetching the appropriate pom.xml from the jar based on jdk version

I don’t think that’s a thing

Although I have not looked at all at the maven support for mrjars

It doesn't look like it is. It could be for local/root on a jar, but for maven a separate fetch is made for the pom, completely unaware of the jdk

is there a way to exclude dependency using alias?

Not right now

sad, I'm running out of ideas how to add jdk8 support without breaking git dependencies to cljfx 😞

maven is easy, I can build poms with different deps and source paths and publish them either as different artifacts, or with different classifiers/activations

but I already have jdk11-specific deps in root deps.edn, and it seems there is no way to exclude them when using git dependency?

you could try using a lib with nil coordinate - that will merge over, but I don't remember how tools.deps handles it (could easily not work, I just don't remember)

using :override-deps?

yeah

doesn't seem to work: given this deps.edn:

{:paths ["src" "jdk11"]
 :deps {org.openjfx/javafx-base {:mvn/version "13"}}
 :aliases {:jdk8 {:paths ["src" "jdk8"]
                  :override-deps {org.openjfx/javafx-base nil}}}}

src:jdk8:/home/vlaaad/.m2/repository/org/clojure/clojure/1.10.1/clojure-1.10.1.jar:/home/vlaaad/.m2/repository/org/openjfx/javafx-base/13/javafx-base-13.jar:/home/vlaaad/.m2/repository/org/clojure/spec.alpha/0.2.176/spec.alpha-0.2.176.jar:/home/vlaaad/.m2/repository/org/clojure/core.specs.alpha/0.2.44/core.specs.alpha-0.2.44.jar:/home/vlaaad/.m2/repository/org/openjfx/javafx-base/13/javafx-base-13-linux.jar

and using :deps in alias seems to interfere with :paths so jdk8 path is not seen, as reported earlier

yeah, I'm going to look at that in a bit once I'm past my morning calls

that's surprising to me

could you also post me your clj -Sdescribe and whether you have anything in ~/.clojure/deps.edn?

wait, you said latest but 1.10.1.148 is not a thing, should be 1.10.1.478

I'm using -Srepro, so ~/.clojure/deps.edn shouldn't be an issue?

I'm using 1.10.1.478, it was a typo

ah, gotcha

on both

clj -A:jdk8 -Srepro -Sforce -Sdescribe

{:version "1.10.1.478"
 :config-files ["/usr/local/lib/clojure/deps.edn" "deps.edn" ]
 :config-user ""
 :config-project "deps.edn"
 :install-dir "/usr/local/lib/clojure"
 :config-dir "/home/vlaaad/.clojure"
 :cache-dir ".cpcache"
 :force true
 :repro true
 :resolve-aliases ""
 :classpath-aliases ""
 :jvm-aliases ""
 :main-aliases ""
 :all-aliases ":jdk8"}

oh, this is the expected behavior

the :paths and :deps in an alias are new with the newest release and REPLACE the project :paths and :deps

if you want to add, you need :extra-paths or :extra-deps

I want to replace both

I thought your complaint above was that the project :paths was not included?

re-reading what you said above...

No, replacement paths are not picked up

ah, it is a bug and I see the fix

and there is a test that should have caught this, but the test is missing the is, so it didn't fail :)

programming is hard, y'all

eastwood will probably warn about such tests, if it works on your code base at all.

@vlaad logged as https://clojure.atlassian.net/browse/TDEPS-142, fixed, and released in tools.deps.alpha 0.8.584, the rest is working its way through to clj

I didn't that see that with clj-kondo, but I'm not running latest version

depends on the example. what's the code?

found it. yes, that's a case I want to improve. currently it only checks the direct children of (deftest ...) like (deftest foo (= 1 2)), but these cases were inside a let: https://github.com/borkdude/clj-kondo/issues/462

@alexmiller If you run the tests through Kaocha, then this might have caught it as well: https://github.com/lambdaisland/kaocha/blob/53d06ab7c56e48cec19bc2ab41a98e0f7b2b860c/doc/clojure_test/assertions.md#clojuretest-assertion-extensions