Hello, I'm using the material-components-web-react package with shadow-cljs. I use the material components in the browser, but also on Node.JS for server side rendering. This used to work fine, but now that I'm trying to update the material-components-web-react package I see the following error in Node.JS:

try node require("@material/textfield/constants.js")

The code works fine in the browser. but only fails on Node. I guess this has something to do with the Javascript module system not being compatible. Any ideas how to solve this?

so, this looks like a problem with the package?

there is a flag in node to enable support for ES6 modules

forgot what it was though

but yeah for the browser stuff is rewritten

for node it just uses node which doesn't yet unterstand impot/export without flags

https://nodejs.org/api/esm.html

not sure how well this works though

Doesn't seem to work either

ah right it is strict and would require .mjs extension

maybe this works https://www.npmjs.com/package/esm

@thheller Cool, that did the trick! Thank you! 🙂

@neo2551 shadow-cljs by default does not support dependencies per build. you currently can only emulate that when using project.clj or deps.edn

Is there a way to set :closure-defines from the command line? I would like to pass the current git commit into the build.

@r0man see the answer I gave @souenzzo yesterday about clj-run

(defn release [path]
  (-> (shadow/get-build-config :your-build-id)
      (assoc :output-dir path)
      (shadow/release* {})))

just switch to (assoc-in [:clojure-defines 'your.ns/git-commit] the-commit)

perfect, I didn't see that. thanks again!

Does anyone know a public project that uses the rum library and builds with shadow-cljs? Rum has some cljsjs dependencies on react stuff and I'm not sure how to replace them to make it work, an example would be great.

@jkr.sw shadow-cljs should be taking care of that already. what is the problem?

@thheller Thanks a lot for your answer

The JS generated by shadow-cljs doesn't seem to contain react. I don't get any errors in console, but my components aren't rendering. The JS file is about 130 Kb smaller than what falls out of lein-cljsbuild, and build report isn't showing any react/rum code.

do you have any manual cljsjs/* files in your project?

No

how are you using it?

At this point I just have rum in my shadow-cljs.edn dependencies (and use rum in my CLJS code).

rum mostly generates code via macro which means the code is in your namespaces not rum namespaces

that should be all you need

Why is my build report missing react though? I've seen it in the examples

not sure. it should definitely be there

please run shadow-cljs clj-repl and ( "cljsjs/react.cljs")

that seems to work: #object[java.net.URL 0x55589ef5 "jar:file:/home/jan/.m2/repository/thheller/shadow-cljsjs/0.0.16/shadow-cljsjs-0.0.16.jar!/cljsjs/react.cljs"]

ok that is fine

which build :target do you use? any custom :js-options?

{:mybuild
  {:target :browser
   :modules {:main {:init-fn my-ui.common/on-js-reload}}}}}

ok that should be fine

no errors in the browser console?

none

and what are you doing in the :init-fn?

just a println, I can see that in the console

no render?

No, I mount my rum component in another place at top level of the main cljs file. That's probably the issue, I think I don't have any main cljs file set anywhere in the shadow-cljs build

ah ok. shadow-cljs just isn't including what you want then

{:mybuild
 {:target :browser
  :modules {:main {:entries [your.actual.main-ns]}}
  :devtools
  {:after-load my-ui.common/on-js-reload}}}

your probably want something like that

shadow-cljs only includes whatever is actually required from your config

https://code.thheller.com/blog/shadow-cljs/2018/02/08/problem-solved-source-paths.html

so you were probably relying on the fact that cljsbuild just includes everything it finds

Yes I was missing the :entries bit (in lein-cljsbuild I have that as :main). It's working now! Thank you very much!

could just use :init-fn to call what you are now calling at the top level instead of calling it

that ensures that its only called once even if you live-reload that file

So here's probably a dumb idea. Everytime I run my app, I get warnings from library code. For example:

[:app] Build completed. (1038 files, 8 compiled, 4 warnings, 11.03s)

------ WARNING #1 --------------------------------------------------------------
 File: zprint/focus.cljc:100:47
--------------------------------------------------------------------------------
  97 |         #_(println "range-ssv: start:" start "nwpath:" nwpath)
  98 |         start (skip-whitespace-ssv ssv start)
  99 |         ssv-next (next-ssv ssv start)
 100 |         end (if (and ssv-next (not= start 0)) (dec ssv-next) (dec (count ssv)))]
-----------------------------------------------------^--------------------------
 cljs.core/-, all arguments must be numbers, got [#{nil clj-nil} number] instead
--------------------------------------------------------------------------------
 101 |     #_(println "range-ssv:" [start end])
 102 |     [start end]))
--------------------------------------------------------------------------------

------ WARNING #2 --------------------------------------------------------------
 File: com/rpl/specter/impl.cljc:786:6
--------------------------------------------------------------------------------
 783 |          val))
 784 | 
 785 |      (mk-late-fn-records)
 786 |      (mk-late-fn)))
------------^-------------------------------------------------------------------
 Use of undeclared Var com.rpl.specter.impl/java
--------------------------------------------------------------------------------
 787 | 
 788 | #?(:clj
 789 |    (defn static-fn-code [afn args]
 790 |      `(~afn [email protected]))
--------------------------------------------------------------------------------

------ WARNING #3 --------------------------------------------------------------
 File: com/rpl/specter.cljc:1275:19
--------------------------------------------------------------------------------
1272 |           ns (namespace structure)]
1273 |       (cond (keyword? structure) (keyword ns new-name)
1274 |             (symbol? structure) (symbol ns new-name)
1275 |             :else (i/throw-illegal "NAME can only be used on symbols or keywords - " structure)
-------------------------^------------------------------------------------------
 Use of undeclared Var com.rpl.specter/java
--------------------------------------------------------------------------------
1276 |             ))))
1277 | 
1278 | (defnav ^{:doc "Navigates to the namespace portion of the keyword or symbol"}
1279 |   NAMESPACE
--------------------------------------------------------------------------------

These build reports are really a great feature. I wouldn't have guessed that just requiring cljs.pprint yields almost +100 Kb after optimizations

It seems like you can’t have both an :http-handler fn, and a :proxy-url, right? Because the proxy will take over.

So if I want to do something fancy, I need drop the proxy-url and do the proxy on my own.

Is there some reliable way at runtime (that is, no macros) to get the filename of the file where a function was defined? OK to only work in dev mode.

@hoopes I agree that its unfortunate. I opened issues on the libs I know about and most of them are fixed already. https://github.com/nathanmarz/specter/issues/267

not sure if there was an actual specter release though.

don't know how I feel about ignoring warnings

yeah, i know it would be a gross hack

but it would make it a lot easier to see what i screwed up 🙂

would it be enough to make warnings in code from libs just "shorter" so they don't show a source excerpt?

(since you can't do anything about them anyways)

or even a different color, or whatever - maybe the non-lib errors are brighter, something that i can tell at a glance that it's actually my code, and not something i can (somewhat) safely ignore

@jkr.sw yeah currently cljs.pprint can't be optimized by Closure at all so it gets really huge. https://dev.clojure.org/jira/browse/CLJS-2885

@orestis no that info would only be available via macros

proxy stuff is currently not as flexible as I'd like so yeah it current is one or the other not both

if you need more advanced server setups you should be using your own anyways

the server doesn't need to do anything special for shadow-cljs. just serve the files, nothing else.

@hoopes I'll start by re-ordering the warnings I guess. So warnings from local code come before library code

right now they are in dependency order which isn't useful for that

this is just my personal preference, so feel free to ignore, but the easiest ones to see are at the bottom (especially when you get the warnings over and over), so i'd prefer "mine" at the end

hmm true

but saying i'd prefer to the BDFL of shadow-cljs is a little presumptuous, so do what you think is best 🙂

its tricky. don't want to print too much but also not too little 😛

if only there was a way to not do all this in the terminal and have a richer interface for warnings 😉

like some sort of page, on a web of some kind

like http://localhost:9630/builds/app but better 😉

After move to lein-tools-deps broke my shadow-cljs build. "release" build still works But when I use (shadow/watch :main) from repl:

[:main] Build failure:
The required namespace "goog" is not available, it was required by "cljs/user.cljs".

check (io/resource "goog/base.js") look like the closure lib may be missing?

quick question: is there a command to watch a build in advanced compilation?

no. that must be triggered manually since they generally take too long for watch

got it. loading a js library into the client at runtime. trying to call it errors out, likely due to advanced compilation

wondering what the best approach to debug this is

shadow-cljs release your-build --pseudo-names

or shadow-cljs check your-build

check isn't totally reliable but sometimes can help spot externs issues

and always set :compiler-options {:infer-externs :auto}

what’s the difference between true/auto for infer-externs?

:auto enables it for all your sources

true requires you to (set! *warn-on-infer* true) for every source you want to enable it for

I seem to get this when using checkouts

ZipException too many length or distance symbols java.util.zip.InflaterInputStream.read (InflaterInputStream.java:164)

relevant trace:

[java.util.zip.InflaterInputStream read "InflaterInputStream.java" 164]
               [java.io.FilterInputStream read "FilterInputStream.java" 133]
               [java.io.BufferedInputStream read1 "BufferedInputStream.java" 284]
               [java.io.BufferedInputStream read "BufferedInputStream.java" 345]
               [sun.nio.cs.StreamDecoder readBytes "StreamDecoder.java" 284]
               [sun.nio.cs.StreamDecoder implRead "StreamDecoder.java" 326]
               [sun.nio.cs.StreamDecoder read "StreamDecoder.java" 178]
               [java.io.InputStreamReader read "InputStreamReader.java" 184]
               [java.io.BufferedReader fill "BufferedReader.java" 161]
               [java.io.BufferedReader read1 "BufferedReader.java" 212]
               [java.io.BufferedReader read "BufferedReader.java" 286]
               [java.io.Reader read "Reader.java" 140]
               [$fn__11010 invokeStatic "io.clj" 337]
               [$fn__11010 invoke "io.clj" 334]
               [clojure.lang.MultiFn invoke "MultiFn.java" 238]
               [$copy invokeStatic "io.clj" 406]
               [$copy doInvoke "io.clj" 391]
               [clojure.lang.RestFn invoke "RestFn.java" 425]
               [clojure.core$slurp invokeStatic "core.clj" 6871]
               [clojure.core$slurp doInvoke "core.clj" 6862]
               [clojure.lang.RestFn invoke "RestFn.java" 410]
               [shadow.cljs.devtools.server.npm_deps$get_deps_from_classpath$fn__25207 invoke "npm_deps.clj" 164]
               [clojure.core$map$fn__5587 invoke "core.clj" 2747]
               [clojure.lang.LazySeq sval "LazySeq.java" 40]
               [clojure.lang.LazySeq seq "LazySeq.java" 49]
               [clojure.lang.Cons next "Cons.java" 39]
               [clojure.lang.RT next "RT.java" 706]
               [clojure.core$next__5108 invokeStatic "core.clj" 64]
               [clojure.core.protocols$fn__7852 invokeStatic "protocols.clj" 169]
               [clojure.core.protocols$fn__7852 invoke "protocols.clj" 124]
               [clojure.core.protocols$fn__7807$G__7802__7816 invoke "protocols.clj" 19]
               [clojure.core.protocols$seq_reduce invokeStatic "protocols.clj" 31]
               [clojure.core.protocols$fn__7835 invokeStatic "protocols.clj" 75]
               [clojure.core.protocols$fn__7835 invoke "protocols.clj" 75]
               [clojure.core.protocols$fn__7781$G__7776__7794 invoke "protocols.clj" 13]
               [clojure.core$reduce invokeStatic "core.clj" 6748]
               [clojure.core$into invokeStatic "core.clj" 6815]
               [clojure.core$into invoke "core.clj" 6807]
               [shadow.cljs.devtools.server.npm_deps$get_deps_from_classpath invokeStatic "npm_deps.clj" 168]
               [shadow.cljs.devtools.server.npm_deps$get_deps_from_classpath invoke "npm_deps.clj" 157]
               [shadow.cljs.devtools.server.npm_deps$main invokeStatic "npm_deps.clj" 204]
               [shadow.cljs.devtools.server.npm_deps$main invoke "npm_deps.clj" 199]

im running shadow-cljs as a library, i.e. executing (shadow-cljs.npm-deps/main {} nil) from my program

weird. maybe a broken .jar file on the classpath?

I had this before on linux where is somehow put an empty .jar file on the classpath

the classpath scanner filters those but npm-deps doesn't I guess

@joelsanchez try this in the REPL

(doseq [url (-> (Thread/currentThread)
                (.getContextClassLoader)
                (.getResources "deps.cljs")
                (enumeration-seq))]
  (try
    (slurp url)
    (catch Exception e
      (prn [:failed url e]))))

seems it happens because I use checkouts though

leiningen doing weird stuff

check jar -tvf /home/joel/.m2/repository/ventas-core/ventas-core/0.0.12-SNAPSHOT/ventas-core-0.0.12-SNAPSHOT.jar

the jar file just seems broken

welp my jar is a bit full of crap but it didnt fail

guess if I remove that js stuff from the jar, which shouldn't be included anyway, it will work

thats odd that it doesn't complain though

but yeah that pretty clearly demonstrates why resources/public is a bad idea as a default 😉

😅 thx

> "too many length or distance symbols"

yes, seems a polite way of saying "your jar's full of crap"

guess maybe it really is just too many files 😛

I removed all of that from the jar, executed lein install, jar -tvf now shows much less files, but I get a different error now

go figure

I swear this didnt happen before checkouts

but dont worry, it's not critical

no idea. never had issues with checkouts and been using them in my work project for years

especially since it doesn't have an issue reading the checkout

that should be a path not jar

hello everyone. has anyone used shadow-cljs with om-next?

I’m getting the following warning

ident? already refers to: cljs.core/ident? being replaced by: om.util/ident?

so?

om-next is pretty much dead AFAICT use fulcro

cljs.core/ident? was added not too long ago. so om.next would need to exclude it to get rid of the warning

thanks @thheller, I wasn’t aware of that..

I’ve been with re-frame for a long time, but I wanted to add SSR to my website, so basically to have an isomorphic app

but it seems to be a pain with re-frame and I was trying to find alternative

#fulcro 🙂

👍 I’ll have a look into it now 🙂