does shadow support .zip files on the classpath? i’m trying to generative-test some really crappy node code from another cljs app. that node code is ultimately bundled into a zip file, and i’m just curious if i have to unzip the file before attempting to run shadow (or if my error is elsewhere)

I was wondering if there is an easy way to have :optimizations :none compilation mode but all in one unique file, concatenated. I have a requirement to leave things readable from a JS dev standpoint but I feel checking in :cache-root is not a clean approach.

@richiardiandrea define "readable". its not like the compiled CLJS code is easily understandable so what do you gain by "readable"?

the "cache" is also not useful for humans to consume as its transit encoded data

@lwhorton .jar files are basically zip files and yes those are supported but you said "node code" so I'm assuming .js files? what kind of code are you talking about? https://shadow-cljs.github.io/docs/UsersGuide.html#_the_classpath

Can you set custom shadow-cljs configuration options based on the deps.edn alias that is passed in on startup via shadow-cljs -A (for instance, only load a preload or set a compiler option if a specific alias is passed)? If not, can you extend an existing build configuration?

what kind of option do you want to pass?

Basically, I want to opt-in to re-frame-10x in development since it’s slowing things down at times, so at the minimum, enable the re_frame.trace.trace_enabled_QMARK_ closure-define flag if an alias is passed to the dev build

you could use clj-run and build a function that uses shadow.cljs.devtools.api to do (shadow/get-build-config :foo) update that config map and then call (shadow/compile* modified-config {})

the cli has nothing to overriding built-in currently

cool, i’ll look into that. yeah, this is probably an edge case. thanks @thheller

@thheller new perf enhancements are quite nice. about a third faster on the initial load

so :node-test returns 0 even when tests are failing

only if you use :autorun. instead use compile and run node the-output.js. that will preserve the proper exit code

ie. do shadow-cljs compile the-test && node out/the-test.js

oh

ok cool that should work

is there an env var / switch to enable :autorun from the command line (it would be super handy)

actually, no

watch should be good enough if it runs the tests

there will probably be some kind of shadow-cljs node-test --ns-regexp foo

so you don't need an actual config

then there could be a --autorun or --compile-only depending on which makes more sense

the goal would be to keep :autorun false in shadow-cljs.edn but be able to run tests in watch mode

yeah

you could set :release {:autorun false} and then use shadow-cljs release the-tests. that way they wouldn't autorun

oh, nice

uhm I am doing yarn shadow-cljs release :test && node .cljs-tests/cd-tests.js but I still have a zero exit code

I blame the extra yarn

try without that first

well, the && is after that

what is the exit of just the node?

0

and its :target :node-test?

Ran 3 tests containing 7 assertions.
2 failures, 1 errors.
arichiardi@EP-LL-10020 ~/git/laputa/continuous-delivery (master *$% u=)$ echo $?
0

yeah

{:target :node-test
                 :main cd.test-runner/-main
                 :autorun true
                 :release {:optimizations :simple
                           :variable-renaming :off
                           :property-renaming :off
                           :pretty-print true
                           :source-map true
                           :autorun false}
                 :output-to ".cljs-tests/cd-tests.js"}

maybe the merge has a problem, let me get rid of :autorun true

thats incorrect. missing a :compiler-options for anything but :autorun

oh man, sorry

but none of that would affect the exit code

trying:

{:target :node-test
                 :main cd.test-runner/-main
                 ;; :autorun true
                 :release {:compiler-options {:optimizations :simple
                                              :variable-renaming :off
                                              :property-renaming :off
                                              :pretty-print true
                                              :source-map true}
                           :autorun false}
                 :output-to ".cljs-tests/cd-tests.js"}

https://github.com/thheller/shadow-cljs/blob/master/src/main/shadow/test/node.cljs#L9-L11

uhm, still zero

wait. why is there is :main?

I see

yeah let me get rid of that

I wanted to test only one namespace

but it is unnecessary

then set :ns-regexp "that.ns"

ugly hack but works for now

yeah so removing the :main makes it work

still odd the reason why it does not do it though, I can open a low-prio issue if you like

well it won't include the main runner ns then

so the defmethod isn't added which sets the exit code

:main is allowed in case you want to use other test frameworks and such

nothing odd about it. should probably just document it.

Ok cool thanks for the support 😉

@thheller We are building out a comprehensive collection of boot tasks for shadow-cljs

https://github.com/degree9/boot-shadow

feedback from any boot users is appreciated

@flyboarder :cache-root is a global config option and cannot be set per build

@thheller thanks! cache disabled!

Is it possible to set a closure define in the config edn from an environment variable?

@grav #shadow/env "THE_THING"

Sweet!