What is the purpose of the socket REPL that's being also started? Is it currently used, or is it there in preparation for future use? I couldn't find anything in the guide, and I'm curious 🙂

@samuel.wagen you are free to use it. I sometimes use it when I get frustrated by some nrepl stuff.

@thheller any idea how to get to the CLJS side from it? piggieback is nrepl only

@samuel.wagen shadow-cljs clj-repl uses the socket REPL. then (shadow/browser-repl) switches it to a CLJS browser repl. or (shadow/node-repl) or (shadow/repl :your-build)

interesting. I tried connecting to the socket repl from unrepl 's unravel

oh of course. clj-repl does an implicit require. if I do (require '[shadow.cljs.devtools.api :as shadow]) then (shadow/repl :build-id) works and I get the cljs repl

ah right. yeah its the .api namespace

clj-repl starts out in shadow.user

(ns shadow.user
  (:require
    [clojure.repl :refer (source apropos dir pst doc find-doc)]
    [clojure.java.javadoc :refer (javadoc)]
    [clojure.pprint :refer (pp pprint)]
    [shadow.cljs.devtools.api :as shadow :refer (help)]))

yep, doing (in-ns 'shadow.user) and (shadow/repl :build-id) does the trick with unravel

https://github.com/thheller/shadow-cljs/wiki

> Cursive does not currently support resolving dependencies via shadow-cljs.edn. You can run shadow-cljs pom to generate a pom.xml and import that using the IntelliJ. How exactly? Curisve still doesn’t recognise detest

@kwladyka you call shadow-cljs pom and then in cursive file -> new -> project from existing sources and select the pom.xml

oh in that way. It doesn’t sound like good solution considering dependencies changing, so each time I will have to start new project.

you don't

but I know there is alternative 🙂

just call shadow-cljs pom again and cursive will automatically update the changed pom.xml

or ask first .. depends on the setting you have there

but you only need to create the project once

weird

check if the file is actually generated properly?

how?

some text editor

ah .. nvm its not pretty printed so its tough to tell if it actually contains something

I guess check if it looks like xml

it looks ok

and you did project from existing sources not module from existing sources?

yes

then I don't know. can you post the pom.xml so I can look at it? just tested it on a dummy project and it worked fine.

that imported completely fine for me?

same intellij version

I have no idea why

or maybe… I have 1 to check

haha it is funny, but: > @kwladyka you call shadow-cljs pom and then in cursive file -> new -> project from existing sources and select the pom.xml I was selecting pom.xml file. As I see right way is to choose directory contain pom.xml file, not select file directly.

I selected the pom.xml every time never the directory

hmm so maybe it doesn’t work with select directory

where is the source file?

wait what is the problem?

BTW do you recommend solution with pom.xml for cursive or another one? 🙂

I do recommend that yes

I use it myself

but what is the actual problem you have?

with cmd+down I can jump to the source etc.

But with shadow-cljs and Cursive I can’t do both

so your problem is that deftest isn't indented correctly?

or what do you mean by "recognise deftest"?

yes, but it is deeper issue. It is not indent correctly, because Cursive doesn’t see this dependency.

didn't you just say that you can navigate to the source?

normally I can press cmd+down and it will open source code of deftest. With shadow-cljs I can’t so my assumption Cursive can’t find that dependency

ah you mean you can't

sorry if it wasn’t clear

I don't know. It all works completely fine for me

But I opened this project by select directory, not pom.xml. It doesn’t work for me as I mentioned before.

I have really no idea why.

I just tried it with empty folder with only this pom.xml. The same issue.

I don't know what to tell you. I click new -> project -> project from existing sources then select the actual generated pom.xml file. accept a couple times and nothing else

it works fine with the file you just posted and creating the test/boilerplate/example_test.cljs

When you select folder instead of a file does it work the same for you or there is a difference?

you can try cloning this repo https://github.com/shadow-cljs/quickstart-browser and trying it there

it doesn't do anything when I select the directory

just closes the dialog

hmm when I select directory I have this:

hmm that seems to be missing the maven option?

I thought the maven integration was built-in but maybe its a plugin? or disabled for some reason?

hmm doest it mean it is because i don’t have “maeven integration” installed?

I have no idea. maybe?

oh so we probable solved it

I didn't install or mess with any other plugin besides cursive

now I have different dialogs

no, leave all the defaults

just click next till its done

oh yeah it works!

you are the boss 🍻

it is time for take a break and eat dinner 🙂

thank you

so the maven integration was just missing?

yes

I didn’t install it

hmm good to know for future reference

I went to the plugin list and checked maven integration, restart Intellij and it works

@kwladyka if you can, another good option is to use deps.edn to manage dependencies, Cursive is supporting those already in the latest versions

@wilkerlucio It is important to point out that there are some caveats and that support is alpha quality AFAIK

FWIW pom.xml is the most stable and well supported option and we really only need to tell cursive about the deps and source paths

I'm running into an issue using module splitting + shadow-cljs 2.4.24

(recently updated from 2.3.x)

when I run in dev mode, everything works as expected. however when I do a release build, I get an error when the bundle runs

Uncaught TypeError: P.l is not a function
    at main.js:1246

this is my shadow-cljs.edn config for this build:

:dashboard
          {:target :browser
           ;; :module-loader true
           :modules
           {:main {:entries [cambia.web.experience.dashboard.client.core]}
            :icon-row {:entries [cambia.web.experience.dashboard.components.icon-row.client]
                       :depends-on #{:main}}
            }
           :compiler-options {:infer-externs :auto}
           :output-dir "public/dashboard/assets/app/js"
           :asset-path "assets/app/js/"
           :devtools
           {:after-load cambia.web.experience.dashboard.client.core/start-dev}}

commenting out the :icon-row module gets rid of the error

@lilactown add :compiler-options {:infer-externs :auto}

it's present

hehe oh right

no warnings?

😄

only one in a completely unrelated file:

[:dashboard] Compiling ...
------ WARNING #1 --------------------------------------------------------------
 File: cambia/web/experience/dashboard/components/hsa/client.cljs:3:10

 variable $ is undeclared
--------------------------------------------------------------------------------

nil

haven't investigated yet

prbably not unrelated

try running with shadow-cljs release dashboard --pseudo-names and do whatever to trigger the error

it'll give you a more readable hint at the error location

kk

it might also be a global variable conflict

if the error goes away with --pseudo-names thats most likely the issue

...it did 😅

testing it again without pseudo-names just to be sure

you can try adding :compiler-options {:output-wrapper true} or find out how the global P is defined and what it is

yep, removing pseudo-names triggers the error

:output-wrapper isn't great when using modules so you should rather find out where that clashing global is coming from

you can then add externs for it so closure doesn't use that variable

just type P in the browser console and see if the object provides any clues

:output-wrapper did fix it. what are the concerns with modules?

output gets larger. not super important since gzip takes care of most of it

still .. fixing it the other way isn't much harder either

I see

is there no way to dump a map from munged names to original names?

not really complaining but I did notice that going from 2.3.x => 2.4.24 that my release bundle got bigger by about 4x (224kb to 804kb)

source maps do that

> P
ƒ Promise() { [native code] }

what? thats not normal

you can compile with shadow-cljs release dashboard --source-maps

wait nevermind that won't tell you where P comes from

do you have the P defined in the page when you remove the script tag for your JS code?

or asked another way: are there any other script tags in the page besides your CLJS code?

there are, I'll try that out

going from 2.3 to 2.4 should definitely not make your build larger though

and certainly not by that amount

generate a build report and see where all the bytes come from: https://shadow-cljs.github.io/docs/UsersGuide.html#_build_report

hmm. with sourcemaps on, the error takes me to mount.core

👍 will do once I figure this out

yeah nevermind that. its a confusing error since closure thinks it created the P variable and points you to the location where it created it

but its var was replaced by something else

some npm deps forcefully create some globals and can cause these issues

I think leaflet always creates window.L

:output-wrapper guards you against such things but makes the build larger by 5% or so

but nowhere near 4x

could be one of the polyfills or analytics scripts that I have to use :face_with_rolling_eyes:

I'm okay with a 5% increase if I (or my team, who has no idea how to debug this stuff :P) don't need to worry about this

well you know thats its P so the simple fix is to create externs/dashboard.txt with one line global:P and done

https://shadow-cljs.github.io/docs/UsersGuide.html#_simplified_externs

but yeah :output-wrapper is generally safer. you can always optimize that away later.

is the "Optimized" size in the build report the gzipped size or real size?

real size

I don't see anything super offensive - it looks like clojure.core is the largest offender

generating a build report from the 2.3.x branch for comparison now

ah hm, the incantation isn't there

not sure in which version I added the build reports though

how large is cljs.core?

184.63kb

thats about normal and would have been the same in 2.3

but that also gzips down to like 30kb so its no biggy

hmm. nevermind

on the 2.3 branch I'm seeing about the same when I run the release build locally - 800kb

where are the other 616kb though?

probably mostly npm deps?

yeah

there's another 100kb from clojure.pprint that I could probably get rid of

then 90kb for react-dom, 70kb from bluebird and google-closure-library...

I was comparing it to the bundle I currently have deployed - I wonder why there's such a difference

it might be gzipped. that would be embarrassing lol

yep it was gzipped size 😂

sorry for the false alarm!

What is the best way to use cljs REPL with shadow-cljs with cursive? https://github.com/thheller/shadow-cljs/wiki/Cursive#connecting-to-a-shadow-repl ?

https://shadow-cljs.github.io/docs/UsersGuide.html#nREPL

set fixed :nrepl {:port <number>}

and connect to that via cursive Clojure REPL -> Remote

then do the watch and nrepl-select described in the guide

@thheller I wanted to investigate a bit how to add REPL support for :node-test and I see that you are disabling :devtools explicitly?

is it because of stable namespaces are needed there and we don't have one? (I actually though we always have a main entry point autogenerated)

I could use the normal :node-script target with a REPL but I don't know if the tests are compiled there