Fork me on GitHub
#scittle
<
2022-12-22
>
Richie18:12:27

The timeout doesn’t get cleared and “finally” doesn’t print. I pasted this snippet into a shadow-cljs project and it works there but not when I use scittle. I can make a repo with a repro.

Richie18:12:59

Clicking “show/hide” adds a new callback but doesn’t clear the last one.

borkdude19:12:25

it seems the finally block isn't running when you click

borkdude19:12:56

I'll take a look

borkdude19:12:34

it might be because the predicate should be seq? instead of list? here - I've seen that before https://github.com/babashka/sci.configs/blob/0702ea5a21ad92e6d7cca6d36de84271083ea68f/src/sci/configs/reagent/reagent.cljs#L38

borkdude19:12:57

That was exactly it

🎉 1
borkdude19:12:25

I've been meaning to do a scittle release anyway, so this came just in time, thanks :)

borkdude19:12:24

Hmm, it was something else, but I'll figure it out. Something with advanced compilation

Richie20:12:10

Cool, I’ll check it out!

Richie20:12:29

1  (ns main
2    (:require
     ^--- Could not find namespace cljs.pprint.
3     [cljs.pprint :refer [pprint]]
I’m sure it worked before.

Richie20:12:17

The other bug is fixed though!

borkdude21:12:17

Hmm.... I'll have another look

borkdude21:12:25

Did you include the pprint module?

Richie21:12:29

I downloaded them so that the page works as a “newtab” extension.

Richie21:12:04

same error

Richie21:12:33

Yea, no error if I use 0.4.11.

borkdude21:12:08

Darn, I'll take a look again then

borkdude21:12:04

@UPD88PGNT Can you try with 0.5.13?

borkdude21:12:17

I should really have some automated tests for this

borkdude21:12:45

Maybe @UE21H2HHD will get bored soon and he wants to write some etaoin tests for this ;-)

simple_smile 1
borkdude22:12:38

btw I got where the error came from now

Richie22:12:10

Cool. It looks fixed.

👍 1
borkdude22:12:58

The ultimate release!

👍 1
borkdude20:12:07

https://github.com/babashka/scittle: execute Clojure(Script) directly from browser script tags via SCI! v0.5.13 (2022-12-23) • Fix reagent with-let macro with advanced compiled builds • Upgrade promesa and shadow-cljs • Fix #queue literal • SCI: performance improvements

thanks2 1