@U04V15CAJ does kondo report edn analysis now?

I just tried on the playground and it seemed to

that's nice, didn't know about it do we need any additional flag to kondo report edn analysis?

could you share what you did on playground?

I'm afraid kondo report findings (the diagnostics) but not include on analysis, if so we would need to change that on kondo first

what'cha talking about? ;)

What's needed to add edn support to clojure-lsp, eric's asking if kondo reports edn analysis now

I've tried on the playground & locally and both seem to handle my edn files

Please be specific in what you mean by edn support

and what you expect clojure-lsp and clj-kondo to do

clj-kondo reports common errors in edn files, like syntax errors

but it doesn't analyze any code expressions in it (yet)

Mainly to have imenu pick up the outlines & references, basically what the linked issue is asking for

keyword analysis of edn for example

Right

Like how lsp-mode handles yaml or json

yep, we would need keyword analysis for edn files which I think kondo doesn't report yet as borkdude mentioned

Ah I see

@U043RSZ25HQ if you could open a issue on clj-kondo about that, would help a lot

Sure thing 🙂

I think this is the related issue: https://github.com/clj-kondo/clj-kondo/issues/1902

hum, it should overlap a little indeed, I think supporting edn analysis ignoring quoted for now would be already a tremendous improvement though

what kind of keywords would be useful for analysis? please come up with some useful examples in the clj-kondo issue

Sure thing, I'll add some examples 🙂

for clojure-lsp the keyword name, location and filename are already enough for find-references work

that's not an example

I mean, I can't remember when I ever wanted to navigate keywords in deps.edn so please help my imagination - also describing in this issue will help collect upvotes

I'm adding some examples now 😄

At Nubank it's pretty common to have edn files at resources folder for configurations and being able to find the references of those keywords in the code and vice versa would be pretty good.

Done 🙂 Hopefully that helps

And yeah at juxt we do something similar, there's also https://github.com/juxt/site that has the whole openapi spec as an edn file

> Done 🙂 Hopefully that helps Where?

On the issue

https://github.com/clj-kondo/clj-kondo/issues/1926

Can you make the examples self-contained? I peeked a little bit and several things you mention there aren't about keywords at all?

I'll skim through kondo's docs and try and add some expected kondo output 🙂 Think there might be some misunderstanding on my end

I mean, it would be nice if the person reading the issue wouldn't have to visit external links, but could just read the issue itself

I'll do that too 🙂

and as I said, the other issue will likely take care of this already. A keyword is something starting with a colon: :foo . A symbol is something like foo/bar . Your issue talks about keywords.

Keywords are what I'm interested in here yes 🙂

hum, for me the buffer shows the markdown properly:

there is lsp-ui-doc for that but I personally don't like it

Hmm, it seems something is quite broken with my LSP setup for Emacs, it doesnt even show docs for defn

Oh, that's expected, there is one macro or other that kondo analysis has only few info, but are pretty rare like defn and def