Hey all, I have been uncertain about this for a while now. Can anyone shed some light? Can I create and deref a re-frame subscription inside a re-frame event handler or not? The FAQ entry below says I should not, but I’m not sure if it is outdated info or not. The alternative methods proposed by the FAQ entry seem a bit annoying to me. I’m curious if the approaches shown in the FAQ are what you all are doing. https://github.com/day8/re-frame/blob/master/docs/FAQs/UseASubscriptionInAnEventHandler.md

@harishtella I agree it is annoying. I pass the data in instead

The entry is not outdated.

Oh, why didn’t I think of that. As in the reagent component makes the subscription needed, and then passes the value into the event dispatch vector.

That would be one way to handle that, yes. For some situations. Not a universal solution though.

For simple things, I generally grab the data directly from the cofx / app-db. I'm not sure if that's a particularly bad practice or not, though.

It's fine if you're fine with duplicating the logic. Sometimes it's acceptable or even desirable, sometimes it's not.

re-frame certainly doesn't care about that.

This is kind of what I had in mind.

(defn search-form
  []
  (let [needed-val (rf/subscribe [:my-sub])]
    (fn []
      [:div#search-form
       [:button {:on-click #(rf/dispatch [:my-event @needed-val])

No, don't do that.

You have to deref the sub first.

Oh right, of course.

https://github.com/day8/re-frame/issues/564

Just remove the extra (fn [] ...) and move that @ right in front of (rf/subscribe ...) and you're all set.

(defn search-form
  []
  (let [needed-val @(rf/subscribe [:my-sub])]
    [:div#search-form
      [:button {:on-click #(rf/dispatch [:my-event needed-val])}]]))

Since you're referencing that, if you have a chance to read the docs I wrote for that issues and comment on anything that needs more work that would be helpful